Re: [PATCH v3 2/2] IB/core: Add generic function to extract IB speed from netdev

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On Sun, Jun 11, 2017 at 08:44:50AM +0300, Yuval Shaia wrote:
> Logic of retrieving netdev speed from net_device and translating it to
> IB speed is implemented in rxe, in usnic and in bnxt drivers.
>
> Define new function which merges all.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> v0 -> v1:
> 	* Invite usnic to the party.
> v1 -> v2:
> 	* Utilize __ethtool_get_link_ksettings
> 	* Rename to ib_get_eth_speed
> 	* Add some validation checks
> 	* Implement get_netdev in usnic
> v2 -> v3:
> 	* Split to two separate patches
> ---
>  drivers/infiniband/core/verbs.c              | 55 ++++++++++++++++++++++++++++
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c     | 49 ++-----------------------
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 31 +++-------------
>  drivers/infiniband/sw/rxe/rxe_verbs.c        | 53 +++------------------------
>  include/rdma/ib_verbs.h                      |  1 +
>  5 files changed, 71 insertions(+), 118 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]