From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works) Date: Tue, 13 Jun 2017 16:02:47 +0200 Message-ID: <20170613140247.GF29589@mail.corp.redhat.com> References: <20170608203904.73abb5e1@lxorguk.ukuu.org.uk> <0d3a087b-ee57-05be-a32a-a5610127db71@redhat.com> <05b492e4-5b76-5665-18a8-4ceddb15d220@redhat.com> <20170613134128.GE29589@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20170613134128.GE29589-/m+UfqrgI5QNLKR9yMNcA1aTQe2KTcn/@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jiri Kosina Cc: Hans de Goede , Linus Torvalds , Alan Stern , Alan Cox , Greg KH , USB list , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-input@vger.kernel.org On Jun 13 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 13 2017 or thereabouts, Jiri Kosina wrote: > > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of > > hid.git, and if no more issues are discovered, I'll push that to Linus > > this week so that we finally get rid of this long-lasting PITA (while > > still heading towards 'automatic' proper matching -- Benjamin already had > > some proposals how to tackle this). > > Hi Jiri, > > I tried to cook some script that formats the list in the same way than > yours. > > I just noticed that you have in CONFIG_HID_CHICONY: > { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) }, > while in v4.12-rc5 it's: > { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_AK1D) }, > ^^^^^^^ False alert on this one. I applied Jiri's patch on top of his for-next branch, and in this branch, this has been renamed into USB_DEVICE_ID_ASUS_AK1D. > > Rest is almost OK with respect to device/driver allocation: > > Also, comparing the raw number of devices, there are 356 devices in > 4.12-rc5, and you have 360 in your patch: > - { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL) } > is added twice (the one in CONFIG_HID_LOGITECH should be dropped IMO). Only this one is would require a change now. Cheers, Benjamin > - { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_HUION_TABLET) }, > appeared, which is fine according to hid-uclogic.c > - The two bluetooth devices for hid-gfrm.c are legitimate too. > > So fixing the extra USB_DEVICE_ID_LOGITECH_G920_WHEEL and the messed up > USB_DEVICE_ID_CHICONY_AK1D should be enough to have it in Linus' tree. > > BTW, the merge with your for-next branch is going to be tricky :( > > Cheers, > Benjamin > > > > > Thanks, > > > > -- > > Jiri Kosina > > SUSE Labs > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html