From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3FA9621A16ECF for ; Tue, 13 Jun 2017 14:33:57 -0700 (PDT) Date: Tue, 13 Jun 2017 15:35:11 -0600 From: Ross Zwisler Subject: Re: [PATCH 2/2] mm: always enable thp for dax mappings Message-ID: <20170613213511.GB5135@linux.intel.com> References: <149713136649.17377.3742583729924020371.stgit@dwillia2-desk3.amr.corp.intel.com> <149713137723.17377.8854203820807564559.stgit@dwillia2-desk3.amr.corp.intel.com> <20170612120714.zypyvp3e4zypqfvf@black.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Jan Kara , "linux-nvdimm@lists.01.org" , Christoph Hellwig , Linux MM , linux-fsdevel , Andrew Morton , "Kirill A. Shutemov" List-ID: On Mon, Jun 12, 2017 at 07:47:19AM -0700, Dan Williams wrote: > On Mon, Jun 12, 2017 at 5:07 AM, Kirill A. Shutemov > wrote: > > On Sat, Jun 10, 2017 at 02:49:37PM -0700, Dan Williams wrote: > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> index c4706e2c3358..901ed3767d1b 100644 > >> --- a/include/linux/huge_mm.h > >> +++ b/include/linux/huge_mm.h > >> @@ -1,6 +1,8 @@ > >> #ifndef _LINUX_HUGE_MM_H > >> #define _LINUX_HUGE_MM_H > >> > >> +#include > >> + > > > > It means now depends on . I don't think it's a > > good idea. > > Seems to be ok as far as 0day-kbuild-robot is concerned. The > alternative is to move vma_is_dax() out of line. I think > transparent_hugepage_enabled() is called frequently enough to make it > worth it to keep it inline. Yea, I played with moving vma_is_dax() to include/linux/mm.h instead, but ran into the issue where IS_DAX() is defined in include/linux/fs.h. So, any way we slice it we end up requiring both MM and FS includes for this to work. Since the way you have it here apparently works and passes zero-day, my vote is to just go with it. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 13 Jun 2017 15:35:11 -0600 From: Ross Zwisler To: Dan Williams Cc: "Kirill A. Shutemov" , Andrew Morton , Jan Kara , "linux-nvdimm@lists.01.org" , Linux MM , linux-fsdevel , Ross Zwisler , Christoph Hellwig Subject: Re: [PATCH 2/2] mm: always enable thp for dax mappings Message-ID: <20170613213511.GB5135@linux.intel.com> References: <149713136649.17377.3742583729924020371.stgit@dwillia2-desk3.amr.corp.intel.com> <149713137723.17377.8854203820807564559.stgit@dwillia2-desk3.amr.corp.intel.com> <20170612120714.zypyvp3e4zypqfvf@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Mon, Jun 12, 2017 at 07:47:19AM -0700, Dan Williams wrote: > On Mon, Jun 12, 2017 at 5:07 AM, Kirill A. Shutemov > wrote: > > On Sat, Jun 10, 2017 at 02:49:37PM -0700, Dan Williams wrote: > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> index c4706e2c3358..901ed3767d1b 100644 > >> --- a/include/linux/huge_mm.h > >> +++ b/include/linux/huge_mm.h > >> @@ -1,6 +1,8 @@ > >> #ifndef _LINUX_HUGE_MM_H > >> #define _LINUX_HUGE_MM_H > >> > >> +#include > >> + > > > > It means now depends on . I don't think it's a > > good idea. > > Seems to be ok as far as 0day-kbuild-robot is concerned. The > alternative is to move vma_is_dax() out of line. I think > transparent_hugepage_enabled() is called frequently enough to make it > worth it to keep it inline. Yea, I played with moving vma_is_dax() to include/linux/mm.h instead, but ran into the issue where IS_DAX() is defined in include/linux/fs.h. So, any way we slice it we end up requiring both MM and FS includes for this to work. Since the way you have it here apparently works and passes zero-day, my vote is to just go with it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org