All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: rth@twiddle.net, agraf@suse.de,
	Aurelien Jarno <aurelien@aurel32.net>,
	thuth@redhat.com, david@redhat.com,
	Miroslav Benes <mbenes@suse.cz>
Subject: [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model
Date: Tue, 13 Jun 2017 23:47:36 +0200	[thread overview]
Message-ID: <20170613214736.19963-4-david@redhat.com> (raw)
In-Reply-To: <20170613214736.19963-1-david@redhat.com>

This allows botting a recent linux kernel (e.g. compiled for z900) and
using mvcos for uaccess:

qemu-system-s390x ... -cpu qemu,mvcos=on ...

While at it, correctly fake its abscence.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/cpu_models.c | 1 +
 target/s390x/mem_helper.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index c508ae1..348e760 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -682,6 +682,7 @@ static void add_qemu_cpu_model_features(S390FeatBitmap fbm)
         S390_FEAT_LONG_DISPLACEMENT_FAST,
         S390_FEAT_ETF2_ENH,
         S390_FEAT_STORE_CLOCK_FAST,
+        S390_FEAT_MOVE_WITH_OPTIONAL_SPEC,
         S390_FEAT_GENERAL_INSTRUCTIONS_EXT,
         S390_FEAT_EXECUTE_EXT,
         S390_FEAT_STFLE_45,
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index cb27465..e0a5de0 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -1508,6 +1508,9 @@ uint32_t HELPER(mvcos)(CPUS390XState *env, uint64_t dest, uint64_t src,
     HELPER_LOG("%s dest %" PRIx64 ", src %" PRIx64 ", len %" PRIx64 "\n",
                __func__, dest, src, len);
 
+    if (!s390_has_feat(S390_FEAT_MOVE_WITH_OPTIONAL_SPEC)) {
+        program_interrupt(env, PGM_OPERATION, 6);
+    }
     if (!(env->psw.mask & PSW_MASK_DAT)) {
         program_interrupt(env, PGM_SPECIAL_OP, 6);
     }
-- 
2.9.3

  parent reply	other threads:[~2017-06-13 21:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 21:47 [Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it David Hildenbrand
2017-06-13 21:47 ` [Qemu-devel] [PATCH v1 1/3] target/s390x: change PSW_SHIFT_KEY David Hildenbrand
2017-06-14  7:05   ` Thomas Huth
2017-06-13 21:47 ` [Qemu-devel] [PATCH v1 2/3] target/s390x: implement mvcos instruction David Hildenbrand
2017-06-14  4:41   ` Richard Henderson
2017-06-14  7:22     ` David Hildenbrand
2017-06-14 14:30       ` Richard Henderson
2017-06-14 17:02         ` David Hildenbrand
2017-06-14  7:37   ` Thomas Huth
2017-06-14  7:56     ` David Hildenbrand
2017-06-14 20:00       ` Thomas Huth
2017-06-14 23:44         ` Richard Henderson
2017-06-13 21:47 ` David Hildenbrand [this message]
2017-06-14  4:44   ` [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model Richard Henderson
2017-06-14  7:03     ` David Hildenbrand
2017-06-14  7:40       ` Thomas Huth
2017-06-13 21:57 ` [Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613214736.19963-4-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=mbenes@suse.cz \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.