From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Date: Tue, 13 Jun 2017 21:55:05 +0300 Message-ID: <20170613215454-mutt-send-email-mst@kernel.org> References: <1497004901-30593-1-git-send-email-wei.w.wang@intel.com> <1497004901-30593-4-git-send-email-wei.w.wang@intel.com> <20170613200049-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wei Wang , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, Matthew Wilcox To: Dave Hansen Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org On Tue, Jun 13, 2017 at 10:59:07AM -0700, Dave Hansen wrote: > On 06/13/2017 10:56 AM, Michael S. Tsirkin wrote: > >> +/* The size of one page_bmap used to record inflated/deflated pages. */ > >> +#define VIRTIO_BALLOON_PAGE_BMAP_SIZE (8 * PAGE_SIZE) > > At this size, you probably want alloc_pages to avoid kmalloc > > overhead. > > For slub, at least, kmalloc() just calls alloc_pages() basically > directly. There's virtually no overhead. > > OK then. -- MST -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753949AbdFMSzX (ORCPT ); Tue, 13 Jun 2017 14:55:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886AbdFMSzV (ORCPT ); Tue, 13 Jun 2017 14:55:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 134CD20A8A Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 134CD20A8A Date: Tue, 13 Jun 2017 21:55:05 +0300 From: "Michael S. Tsirkin" To: Dave Hansen Cc: Wei Wang , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, Matthew Wilcox Subject: Re: [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Message-ID: <20170613215454-mutt-send-email-mst@kernel.org> References: <1497004901-30593-1-git-send-email-wei.w.wang@intel.com> <1497004901-30593-4-git-send-email-wei.w.wang@intel.com> <20170613200049-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 13 Jun 2017 18:55:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2017 at 10:59:07AM -0700, Dave Hansen wrote: > On 06/13/2017 10:56 AM, Michael S. Tsirkin wrote: > >> +/* The size of one page_bmap used to record inflated/deflated pages. */ > >> +#define VIRTIO_BALLOON_PAGE_BMAP_SIZE (8 * PAGE_SIZE) > > At this size, you probably want alloc_pages to avoid kmalloc > > overhead. > > For slub, at least, kmalloc() just calls alloc_pages() basically > directly. There's virtually no overhead. > > OK then. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKqyF-0008UI-UD for qemu-devel@nongnu.org; Tue, 13 Jun 2017 14:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKqyD-0006Xj-V3 for qemu-devel@nongnu.org; Tue, 13 Jun 2017 14:55:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55480) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dKqyD-0006XB-PJ for qemu-devel@nongnu.org; Tue, 13 Jun 2017 14:55:17 -0400 Date: Tue, 13 Jun 2017 21:55:05 +0300 From: "Michael S. Tsirkin" Message-ID: <20170613215454-mutt-send-email-mst@kernel.org> References: <1497004901-30593-1-git-send-email-wei.w.wang@intel.com> <1497004901-30593-4-git-send-email-wei.w.wang@intel.com> <20170613200049-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Hansen Cc: Wei Wang , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, david@redhat.com, cornelia.huck@de.ibm.com, akpm@linux-foundation.org, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, Matthew Wilcox On Tue, Jun 13, 2017 at 10:59:07AM -0700, Dave Hansen wrote: > On 06/13/2017 10:56 AM, Michael S. Tsirkin wrote: > >> +/* The size of one page_bmap used to record inflated/deflated pages. */ > >> +#define VIRTIO_BALLOON_PAGE_BMAP_SIZE (8 * PAGE_SIZE) > > At this size, you probably want alloc_pages to avoid kmalloc > > overhead. > > For slub, at least, kmalloc() just calls alloc_pages() basically > directly. There's virtually no overhead. > > OK then. -- MST