All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org,
	i.maximets@samsung.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page
Date: Wed, 14 Jun 2017 12:58:15 +0800	[thread overview]
Message-ID: <20170614045815.GG11751@pxdev.xzpeter.org> (raw)
In-Reply-To: <154a8295-381a-b7dd-41b9-d9f720b790f6@samsung.com>

On Tue, Jun 13, 2017 at 03:00:28PM +0300, Alexey Perevalov wrote:
> On 06/13/2017 02:42 PM, Juan Quintela wrote:

[...]

> >>Bitmap is placed into RAMBlock as another postcopy/precopy
> >>related bitmaps.
> >Why are we not using the TARGET_PAGE_SIZE as units of the bitmap?
> Page size per ram block can be different, just to
> reduce whole size of bitmap.

I think one reason that we should use TARGET_PAGE_SIZE not
per-ramblock page size bitmap is that we need to let this
copied_bitmap/recved_bitmap work even during precopy phase, and in
precopy phase we are migrating pages in target page size, not host
page size.

Thanks,

-- 
Peter Xu

  reply	other threads:[~2017-06-14  4:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170613093736eucas1p17c1164431236b6c0b827e607f8598c27@eucas1p1.samsung.com>
2017-06-13  9:36 ` [Qemu-devel] [PATCH v1 0/2] Add bitmap for copied pages in postcopy migration Alexey Perevalov
2017-06-13  9:36   ` [Qemu-devel] [PATCH v1 1/2] migration: postcopy_place_page factoring out Alexey Perevalov
2017-06-13  9:36   ` [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page Alexey Perevalov
2017-06-13 11:42     ` Juan Quintela
2017-06-13 12:00       ` Alexey Perevalov
2017-06-14  4:58         ` Peter Xu [this message]
2017-06-14 12:40       ` Alexey Perevalov
2017-06-14 15:29         ` Juan Quintela
2017-06-15  7:46           ` Alexey
2017-06-14  5:12     ` Peter Xu
2017-06-14  6:39       ` Alexey Perevalov
2017-06-14  6:53         ` Peter Xu
2017-06-14  8:11           ` Alexey Perevalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614045815.GG11751@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=dgilbert@redhat.com \
    --cc=i.maximets@samsung.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.