Re: [Qemu-devel] [PATCH] target/ppc: Fix return value in tcg radix mmu fault handler

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

On Wed, Jun 14, 2017 at 04:44:52PM +1000, Suraj Jitindar Singh wrote:
> The mmu fault handler should return 0 if it was able to successfully
> handle the fault and a positive value otherwise.
> 
> Currently the tcg radix mmu fault handler will return 1 after
> successfully handling a fault in virtual mode. This is incorrect
> so fix it so that it returns 0 in this case.
> 
> The handler already correctly returns 0 when a fault was handled
> in real mode and 1 if an interrupt was generated.
> 
> Fixes: d5fee0bbe68d ("target/ppc: Implement ISA V3.00 radix page fault handler")
> 
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

Applied to ppc-for-2.10, thanks.

> ---
>  target/ppc/mmu-radix64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index de18c0b..69fde65 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -255,5 +255,5 @@ int ppc_radix64_handle_mmu_fault(PowerPCCPU *cpu, vaddr eaddr, int rwx,
>  
>      tlb_set_page(cs, eaddr & TARGET_PAGE_MASK, raddr & TARGET_PAGE_MASK,
>                   prot, mmu_idx, 1UL << page_size);
> -    return 1;
> +    return 0;
>  }

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]