From: "Richard W.M. Jones" <rjones@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI
Date: Wed, 14 Jun 2017 14:12:25 +0100 [thread overview]
Message-ID: <20170614131225.GB31999@redhat.com> (raw)
In-Reply-To: <cover.1497444637.git.jcody@redhat.com>
On Wed, Jun 14, 2017 at 08:53:18AM -0400, Jeff Cody wrote:
> Change from v2:
> Add warning message that this is an unsupported option that may
> be deprecated in the future.
>
> We need to be able to parse the 'filename' option for rbd and iscsi, because
> there may exist images in the wild that have json backing files, that specify
> the filename argument.
>
> Jeff Cody (2):
> block/rbd: enable filename option and parsing
> block/iscsi: enable filename option and parsing
>
> block/iscsi.c | 22 +++++++++++++++++++++-
> block/rbd.c | 22 +++++++++++++++++++++-
> 2 files changed, 42 insertions(+), 2 deletions(-)
ACK series.
Issuing the warning is a good idea too.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2017-06-14 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 12:53 [Qemu-devel] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI Jeff Cody
2017-06-14 12:53 ` [Qemu-devel] [PATCH v2 1/2] block/rbd: enable filename option and parsing Jeff Cody
2017-06-14 12:53 ` [Qemu-devel] [PATCH v2 2/2] block/iscsi: " Jeff Cody
2017-06-14 13:12 ` Richard W.M. Jones [this message]
2017-06-14 13:13 ` [Qemu-devel] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI no-reply
2017-06-14 21:39 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614131225.GB31999@redhat.com \
--to=rjones@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.