From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH iproute2 2/2] tc: m_tunnel_key: add csum/nocsum option
Date: Wed, 14 Jun 2017 13:38:07 -0700 [thread overview]
Message-ID: <20170614133807.2320f98b@xeon-e3> (raw)
In-Reply-To: <20170614213018.364cd85d@griffin>
On Wed, 14 Jun 2017 21:30:18 +0200
Jiri Benc <jbenc@redhat.com> wrote:
> Allows control of UDP zero checksum.
>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> ---
> man/man8/tc-tunnel_key.8 | 18 ++++++++++++++++++
> tc/m_tunnel_key.c | 21 ++++++++++++++++++++-
> 2 files changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/man/man8/tc-tunnel_key.8 b/man/man8/tc-tunnel_key.8
> index 2e569730abbb..e979a74715cb 100644
> --- a/man/man8/tc-tunnel_key.8
> +++ b/man/man8/tc-tunnel_key.8
> @@ -16,6 +16,7 @@ tunnel_key - Tunnel metadata manipulation
> .IR ADDRESS
> .BI id " KEY_ID"
> .BI dst_port " UDP_PORT"
> +.RB "[ " csum " | " nocsum " ]"
>
> .SH DESCRIPTION
> The
> @@ -77,6 +78,23 @@ Outer header destination IP address (IPv4 or IPv6)
> .TP
> .B dst_port
> Outer header destination UDP port
> +.TP
> +.RB [ no ] csum
> +Controlls outer UDP checksum. When set to
> +.B csum
> +(which is default), the outer UDP checksum is calculated and included in the
> +packets. When set to
> +.BR nocsum ,
Does this change the default? Before your patches what was the checksum
setting for the new tunnel.
next prev parent reply other threads:[~2017-06-14 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 19:19 [PATCH net-next 0/2] net: sched: act_tunnel_key: UDP checksums Jiri Benc
2017-06-14 19:19 ` [PATCH net-next 1/2] net: sched: act_tunnel_key: request UDP checksum by default Jiri Benc
2017-06-14 19:19 ` [PATCH net-next 2/2] net: sched: act_tunnel_key: make UDP checksum configurable Jiri Benc
2017-06-14 19:29 ` [PATCH iproute2 1/2] tc: m_tunnel_key: reformat the usage text Jiri Benc
2017-06-14 19:30 ` [PATCH iproute2 2/2] tc: m_tunnel_key: add csum/nocsum option Jiri Benc
2017-06-14 20:38 ` Stephen Hemminger [this message]
2017-06-15 8:21 ` Jiri Benc
2017-06-16 16:12 ` Stephen Hemminger
2017-06-15 18:21 ` [PATCH net-next 0/2] net: sched: act_tunnel_key: UDP checksums David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614133807.2320f98b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.