All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: util-linux@vger.kernel.org
Cc: Karel Zak <kzak@redhat.com>
Subject: libblkid & empty identifier values
Date: Wed, 14 Jun 2017 23:04:34 +0200	[thread overview]
Message-ID: <201706142304.34356@pali> (raw)

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

Hello!

Technically UDF filesystem allows to store empty string values. 
LogicalVolumeIdentifier (label) according to UDF specification shall not 
be null, but it is possible to store empty string there.

Question is, what should libblkid's udf code do if e.g. LABEL identifier 
is empty string? Should it set empty LABEL for libblkid? Or it should 
not set LABEL at all?

Currently in blkid_probe_set_label() is check for len > 1, so empty 
string is not possible to store for LABEL. But when check fails function 
return non-negative value which is understood as succeeded -- even it 
did not store empty string. It does not looks good... Or it is expected?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2017-06-14 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 21:04 Pali Rohár [this message]
2017-06-15  7:52 ` libblkid & empty identifier values Karel Zak
2017-06-15  7:57   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201706142304.34356@pali \
    --to=pali.rohar@gmail.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.