From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] RFC: ARM: dts: imx7d-sdb: swap pad settings for USDHCx 50Mhz and 100Mhz
Date: Thu, 15 Jun 2017 11:39:36 +0800 [thread overview]
Message-ID: <20170615033935.GB5902@dragon> (raw)
In-Reply-To: <1496857542-32200-2-git-send-email-troy.kisky@boundarydevices.com>
On Wed, Jun 07, 2017 at 10:45:42AM -0700, Troy Kisky wrote:
> It does not make sense that 100 Mhz pad settings would use a x2
> setting and 50 Mhz would use a x4 setting, so swap.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Add Dong and Frank for this one as well.
Shawn
> ---
> arch/arm/boot/dts/imx7d-sdb.dts | 72 ++++++++++++++++++++---------------------
> 1 file changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index cab9208..70dcbf4 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -590,31 +590,20 @@
>
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> - MX7D_PAD_SD1_CMD__SD1_CMD 0x59
> - MX7D_PAD_SD1_CLK__SD1_CLK 0x09
> - MX7D_PAD_SD1_DATA0__SD1_DATA0 0x59
> - MX7D_PAD_SD1_DATA1__SD1_DATA1 0x59
> - MX7D_PAD_SD1_DATA2__SD1_DATA2 0x59
> - MX7D_PAD_SD1_DATA3__SD1_DATA3 0x59
> - MX7D_PAD_SD1_CD_B__GPIO5_IO0 0x59 /* CD */
> - MX7D_PAD_SD1_WP__GPIO5_IO1 0x59 /* WP */
> - MX7D_PAD_SD1_RESET_B__GPIO5_IO2 0x59 /* vmmc */
> + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a
> + MX7D_PAD_SD1_CLK__SD1_CLK 0x0a
> + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a
> + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a
> + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a
> + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a
> + MX7D_PAD_SD1_CD_B__GPIO5_IO0 0x5a /* CD */
> + MX7D_PAD_SD1_WP__GPIO5_IO1 0x5a /* WP */
> + MX7D_PAD_SD1_RESET_B__GPIO5_IO2 0x5a /* vmmc */
> >;
> };
>
> pinctrl_usdhc2: usdhc2grp {
> fsl,pins = <
> - MX7D_PAD_SD2_CMD__SD2_CMD 0x59
> - MX7D_PAD_SD2_CLK__SD2_CLK 0x09
> - MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59
> - MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59
> - MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59
> - MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59
> - >;
> - };
> -
> - pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
> - fsl,pins = <
> MX7D_PAD_SD2_CMD__SD2_CMD 0x5a
> MX7D_PAD_SD2_CLK__SD2_CLK 0x0a
> MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5a
> @@ -624,6 +613,17 @@
> >;
> };
>
> + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
> + fsl,pins = <
> + MX7D_PAD_SD2_CMD__SD2_CMD 0x59
> + MX7D_PAD_SD2_CLK__SD2_CLK 0x09
> + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59
> + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59
> + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59
> + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59
> + >;
> + };
> +
> pinctrl_usdhc2_200mhz: usdhc2grp_200mhz {
> fsl,pins = <
> MX7D_PAD_SD2_CMD__SD2_CMD 0x5b
> @@ -638,22 +638,6 @@
>
> pinctrl_usdhc3: usdhc3grp {
> fsl,pins = <
> - MX7D_PAD_SD3_CMD__SD3_CMD 0x59
> - MX7D_PAD_SD3_CLK__SD3_CLK 0x09
> - MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59
> - MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59
> - MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59
> - MX7D_PAD_SD3_DATA3__SD3_DATA3 0x59
> - MX7D_PAD_SD3_DATA4__SD3_DATA4 0x59
> - MX7D_PAD_SD3_DATA5__SD3_DATA5 0x59
> - MX7D_PAD_SD3_DATA6__SD3_DATA6 0x59
> - MX7D_PAD_SD3_DATA7__SD3_DATA7 0x59
> - MX7D_PAD_SD3_STROBE__SD3_STROBE 0x19
> - >;
> - };
> -
> - pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
> - fsl,pins = <
> MX7D_PAD_SD3_CMD__SD3_CMD 0x5a
> MX7D_PAD_SD3_CLK__SD3_CLK 0x0a
> MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5a
> @@ -668,6 +652,22 @@
> >;
> };
>
> + pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
> + fsl,pins = <
> + MX7D_PAD_SD3_CMD__SD3_CMD 0x59
> + MX7D_PAD_SD3_CLK__SD3_CLK 0x09
> + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59
> + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59
> + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59
> + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x59
> + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x59
> + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x59
> + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x59
> + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x59
> + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x19
> + >;
> + };
> +
> pinctrl_usdhc3_200mhz: usdhc3grp_200mhz {
> fsl,pins = <
> MX7D_PAD_SD3_CMD__SD3_CMD 0x5b
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-06-15 3:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 17:45 [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down on USDHCx clock Troy Kisky
2017-06-07 17:45 ` [PATCH 2/2] RFC: ARM: dts: imx7d-sdb: swap pad settings for USDHCx 50Mhz and 100Mhz Troy Kisky
2017-06-15 3:39 ` Shawn Guo [this message]
2017-06-15 4:52 ` A.s. Dong
2017-06-15 3:38 ` [PATCH 1/2] RFC: ARM: dts: imx7d-sdb: remove 100k pull-down on USDHCx clock Shawn Guo
2017-06-15 4:31 ` A.s. Dong
2017-06-15 17:46 ` Troy Kisky
2017-06-27 5:32 ` A.s. Dong
2017-06-27 20:22 ` Troy Kisky
2017-06-27 20:30 ` Fabio Estevam
2017-06-27 20:49 ` Troy Kisky
2017-06-27 23:27 ` Fabio Estevam
2017-06-27 23:49 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615033935.GB5902@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.