From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com
Subject: Re: [PATCH 03/11] fs: add support for an inode to carry stream related data
Date: Thu, 15 Jun 2017 01:17:33 -0700 [thread overview]
Message-ID: <20170615081733.GC10599@infradead.org> (raw)
In-Reply-To: <1497498312-17704-4-git-send-email-axboe@kernel.dk>
On Wed, Jun 14, 2017 at 09:45:04PM -0600, Jens Axboe wrote:
> No functional changes in this patch, just in preparation for
> allowing applications to pass in hints about data life times
> for writes.
>
> Pack the i_write_hint field into a 2-byte hole, so we don't grow
> the size of the inode.
A u8 should be plenty. But talking about the representation -
your write lifetime hints are a 5 option enum basically. I wonder
if we really should encode it as flags, or if we should have an
enum (which could be packed into a 3-bit bitfield) and then pass
it down the stack in that form instead of changing the representation
N times.
next prev parent reply other threads:[~2017-06-15 8:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 3:45 [PATCHSET v4] Add support for write life time hints Jens Axboe
2017-06-15 3:45 ` [PATCH 01/11] block: add support for carrying stream information in a bio Jens Axboe
2017-06-15 3:45 ` [PATCH 02/11] blk-mq: expose stream write stats through debugfs Jens Axboe
2017-06-15 8:16 ` Christoph Hellwig
2017-06-15 14:24 ` Jens Axboe
2017-06-15 3:45 ` [PATCH 03/11] fs: add support for an inode to carry stream related data Jens Axboe
2017-06-15 8:17 ` Christoph Hellwig [this message]
2017-06-15 14:22 ` Jens Axboe
2017-06-15 3:45 ` [PATCH 04/11] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-15 4:15 ` Darrick J. Wong
2017-06-15 4:33 ` Jens Axboe
2017-06-15 8:19 ` Christoph Hellwig
2017-06-15 14:21 ` Jens Axboe
2017-06-15 15:23 ` Jens Axboe
2017-06-16 7:30 ` Christoph Hellwig
2017-06-16 14:35 ` Jens Axboe
2017-06-16 7:33 ` Christoph Hellwig
2017-06-16 14:35 ` Jens Axboe
2017-06-16 14:53 ` Jens Axboe
2017-06-16 15:52 ` Christoph Hellwig
2017-06-16 15:59 ` Jens Axboe
2017-06-16 16:14 ` Jens Axboe
2017-06-16 18:00 ` Christoph Hellwig
2017-06-16 18:02 ` Christoph Hellwig
2017-06-16 19:35 ` Jens Axboe
2017-06-15 11:24 ` Al Viro
2017-06-15 3:45 ` [PATCH 05/11] block: add helpers for setting/checking write hint validity Jens Axboe
2017-06-15 3:45 ` [PATCH 06/11] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-15 3:45 ` [PATCH 07/11] fs: add support for buffered writeback to pass down write hints Jens Axboe
2017-06-15 3:45 ` [PATCH 08/11] ext4: add support for passing in write hints for buffered writes Jens Axboe
2017-06-15 3:45 ` [PATCH 09/11] xfs: " Jens Axboe
2017-06-15 3:45 ` [PATCH 10/11] btrfs: " Jens Axboe
2017-06-15 3:45 ` [PATCH 11/11] nvme: add support for streams and directives Jens Axboe
2017-06-15 8:12 ` [PATCHSET v4] Add support for write life time hints Christoph Hellwig
2017-06-15 14:23 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2017-06-14 19:05 [PATCHSET v3] " Jens Axboe
2017-06-14 19:05 ` [PATCH 03/11] fs: add support for an inode to carry stream related data Jens Axboe
2017-06-14 20:25 ` Christoph Hellwig
2017-06-14 20:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615081733.GC10599@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.