From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCHv2] tests: shell: Add test for ambguity while setting the value
Date: Thu, 15 Jun 2017 11:51:56 +0200 [thread overview]
Message-ID: <20170615095156.GA8936@salvia> (raw)
In-Reply-To: <1497024060-6142-1-git-send-email-mayhs11saini@gmail.com>
On Fri, Jun 09, 2017 at 09:31:00PM +0530, Shyam Saini wrote:
> This test checks bug identified and fixed in the commit mentioned below
> In a statement if there are multiple src data then it would be
> totally ambiguous to decide which value to set.
>
> We don't add this test in python testsuite, because there we only have
> "ok" and "fail" as return code. So, we can't detect 134 != 1 there.
> (both 1 and 134 stats failure)
OK I see, so 134 and 1 refers to the exit code we return to the shell
(or whoever runs nft).
Could you have a look at tests/py/nft-test.py
If the problem is just the exit code, then I suggest you add these
tests to the python infrastructure, then make sure that the python
script checks for 1 for 'fail'.
Could you have a look, please?
next prev parent reply other threads:[~2017-06-15 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 16:01 [PATCHv2] tests: shell: Add test for ambguity while setting the value Shyam Saini
2017-06-12 9:22 ` Pablo Neira Ayuso
2017-06-12 10:46 ` Shyam Saini
2017-06-12 10:49 ` Pablo Neira Ayuso
2017-06-12 11:24 ` Shyam Saini
2017-06-15 9:51 ` Pablo Neira Ayuso [this message]
2017-06-15 10:55 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615095156.GA8936@salvia \
--to=pablo@netfilter.org \
--cc=mayhs11saini@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.