From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v9 3/7] drm: Extend the drm format Date: Thu, 15 Jun 2017 13:21:35 +0300 Message-ID: <20170615102135.GT12629@intel.com> References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com> <1497513611-2814-4-git-send-email-xiaoguang.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1497513611-2814-4-git-send-email-xiaoguang.chen@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Xiaoguang Chen Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kraxel@redhat.com, intel-gvt-dev@lists.freedesktop.org, zhiyuan.lv@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMTUsIDIwMTcgYXQgMDQ6MDA6MDdQTSArMDgwMCwgWGlhb2d1YW5nIENoZW4g d3JvdGU6Cj4gQWRkIG5ldyBkcm0gZm9ybWF0IHdoaWNoIHdpbGwgYmUgdXNlZCBieSBHVlQtZy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBYaWFvZ3VhbmcgQ2hlbiA8eGlhb2d1YW5nLmNoZW5AaW50ZWwu Y29tPgo+IC0tLQo+ICBpbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaCB8IDQgKysrKwo+ICAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv dWFwaS9kcm0vZHJtX2ZvdXJjYy5oIGIvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgKPiBp bmRleCA1NWUzMDEwLi4yNjgxODYyIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJt X2ZvdXJjYy5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgKPiBAQCAtMTEz LDYgKzExMywxMCBAQCBleHRlcm4gIkMiIHsKPiAgCj4gICNkZWZpbmUgRFJNX0ZPUk1BVF9BWVVW CQlmb3VyY2NfY29kZSgnQScsICdZJywgJ1UnLCAnVicpIC8qIFszMTowXSBBOlk6Q2I6Q3IgODo4 Ojg6OCBsaXR0bGUgZW5kaWFuICovCj4gIAo+ICsvKiA2NCBicHAgUkdCICovCj4gKyNkZWZpbmUg RFJNX0ZPUk1BVF9YUkdCMTYxNjE2ICBmb3VyY2NfY29kZSgnWCcsICdSJywgJzQnLCAnOCcpIC8q IFs2MzowXSB4OlI6RzpCIDE2OjE2OjE2OjE2IGxpdHRsZSBlbmRpYW4gKi8KPiArI2RlZmluZSBE Uk1fRk9STUFUX1hCR1IxNjE2MTYgIGZvdXJjY19jb2RlKCdYJywgJ0InLCAnNCcsICc4JykgLyog WzYzOjBdIHg6QjpHOlIgMTY6MTY6MTY6MTYgbGl0dGxlIGVuZGlhbiAqLwoKQXJlIHRoZXNlIHN1 cHBvc2VkIHRvIGJlIHRoZSBoYWxmIGZsb2F0IGZvcm1hdHM/IElmIHNvIHRoZSBkb2NzIGFyZQps YWNraW5nLiBBbHNvIHRoaXMgc29ydCBvZiBzdHVmZiBtdXN0IGJlIHNlbnQgdG8gZHJpLWRldmVs IGZvciBldmVyeW9uZQp0byBzZWUuCgpUaGF0IHNhaWQsIEkgZG9uJ3QgcmVhbGx5IGxpa2UgaGF2 aW5nIHRoZW0gaW4gYW55IGd2dCBjb2RlIHVudGlsCnRoZXkncmUgaGFuZGxlZCBieSB0aGUgZHJp dmVyIHByb3Blci4KCj4gKwo+ICAvKgo+ICAgKiAyIHBsYW5lIFJHQiArIEEKPiAgICogaW5kZXgg MCA9IFJHQiBwbGFuZSwgc2FtZSBmb3JtYXQgYXMgdGhlIGNvcnJlc3BvbmRpbmcgbm9uIF9BOCBm b3JtYXQgaGFzCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdFOKVm (ORCPT ); Thu, 15 Jun 2017 06:21:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:13187 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdFOKVl (ORCPT ); Thu, 15 Jun 2017 06:21:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,343,1493708400"; d="scan'208";a="1141522750" Date: Thu, 15 Jun 2017 13:21:35 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Xiaoguang Chen Cc: alex.williamson@redhat.com, kraxel@redhat.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com Subject: Re: [Intel-gfx] [PATCH v9 3/7] drm: Extend the drm format Message-ID: <20170615102135.GT12629@intel.com> References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com> <1497513611-2814-4-git-send-email-xiaoguang.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1497513611-2814-4-git-send-email-xiaoguang.chen@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2017 at 04:00:07PM +0800, Xiaoguang Chen wrote: > Add new drm format which will be used by GVT-g. > > Signed-off-by: Xiaoguang Chen > --- > include/uapi/drm/drm_fourcc.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 55e3010..2681862 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -113,6 +113,10 @@ extern "C" { > > #define DRM_FORMAT_AYUV fourcc_code('A', 'Y', 'U', 'V') /* [31:0] A:Y:Cb:Cr 8:8:8:8 little endian */ > > +/* 64 bpp RGB */ > +#define DRM_FORMAT_XRGB161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */ > +#define DRM_FORMAT_XBGR161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */ Are these supposed to be the half float formats? If so the docs are lacking. Also this sort of stuff must be sent to dri-devel for everyone to see. That said, I don't really like having them in any gvt code until they're handled by the driver proper. > + > /* > * 2 plane RGB + A > * index 0 = RGB plane, same format as the corresponding non _A8 format has > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC