From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dawid Kurek Subject: [PATCH] drm: Reduce scope of 'state' variable Date: Thu, 15 Jun 2017 12:41:42 +0200 Message-ID: <20170615104142.GA29276@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BBDD6E6FE for ; Thu, 15 Jun 2017 10:41:51 +0000 (UTC) Received: by mail-lf0-x232.google.com with SMTP id v20so6580865lfa.1 for ; Thu, 15 Jun 2017 03:41:51 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org U21hbGxlciBzY29wZSByZWR1Y2VzIHZpc2liaWxpdHkgb2YgdmFyaWFibGUgYW5kIG1ha2VzIHVz YWdlIG9mCnVuaW5pdGlhbGl6ZWQgdmFyaWFibGUgbGVzcyBwb3NzaWJsZS4KLS0tCiBkcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pYy5jIHwgNSArKystLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwppbmRleCBmMzI1MDZhLi5l YTVhOWE3IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKQEAgLTEwOCwxMCArMTA4LDExIEBAIHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICoKIGRybV9hdG9taWNfc3RhdGVfYWxsb2Moc3RydWN0IGRybV9kZXZp Y2UgKmRldikKIHsKIAlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcgPSAmZGV2LT5tb2Rl X2NvbmZpZzsKLQlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7CiAKIAlpZiAoIWNvbmZp Zy0+ZnVuY3MtPmF0b21pY19zdGF0ZV9hbGxvYykgewotCQlzdGF0ZSA9IGt6YWxsb2Moc2l6ZW9m KCpzdGF0ZSksIEdGUF9LRVJORUwpOworCQlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUK KwkJCT0ga3phbGxvYyhzaXplb2YoKnN0YXRlKSwgR0ZQX0tFUk5FTCk7CisKIAkJaWYgKCFzdGF0 ZSkKIAkJCXJldHVybiBOVUxMOwogCQlpZiAoZHJtX2F0b21pY19zdGF0ZV9pbml0KGRldiwgc3Rh dGUpIDwgMCkgewotLSAKMi4xMC4wCgoKLS0tClRoaXMgZW1haWwgaGFzIGJlZW4gY2hlY2tlZCBm b3IgdmlydXNlcyBieSBBdmFzdCBhbnRpdmlydXMgc29mdHdhcmUuCmh0dHBzOi8vd3d3LmF2YXN0 LmNvbS9hbnRpdmlydXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbdFOKlw (ORCPT ); Thu, 15 Jun 2017 06:41:52 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34360 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdFOKlv (ORCPT ); Thu, 15 Jun 2017 06:41:51 -0400 Date: Thu, 15 Jun 2017 12:41:42 +0200 From: Dawid Kurek To: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: Reduce scope of 'state' variable Message-ID: <20170615104142.GA29276@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-Antivirus: Avast (VPS 170615-0, 15/06/2017), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. --- drivers/gpu/drm/drm_atomic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f32506a..ea5a9a7 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -108,10 +108,11 @@ struct drm_atomic_state * drm_atomic_state_alloc(struct drm_device *dev) { struct drm_mode_config *config = &dev->mode_config; - struct drm_atomic_state *state; if (!config->funcs->atomic_state_alloc) { - state = kzalloc(sizeof(*state), GFP_KERNEL); + struct drm_atomic_state *state + = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) return NULL; if (drm_atomic_state_init(dev, state) < 0) { -- 2.10.0 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus