From: Al Viro <viro@ZenIV.linux.org.uk>
To: Khazhismel Kumykov <khazhy@google.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Miklos Szeredi <mszeredi@redhat.com>
Subject: Re: Hang/soft lockup in d_invalidate with simultaneous calls
Date: Thu, 15 Jun 2017 11:50:58 +0100 [thread overview]
Message-ID: <20170615105058.GK31671@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CACGdZYLNWyr3j4so-G3gv7V+NHtQ31p4pF_OMe1uYMgaqu4RsQ@mail.gmail.com>
On Mon, Jun 12, 2017 at 04:00:45PM -0700, Khazhismel Kumykov wrote:
> On Fri, Jun 2, 2017 at 11:47 PM, Khazhismel Kumykov <khazhy@google.com> wrote:
> > On Fri, Jun 2, 2017 at 11:20 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >> The thing is, unlike shrink_dcache_parent() we *can* bugger off as
> >> soon as we'd found no victims, nothing mounted and dentry itself
> >> is unhashed. We can't do anything in select_collect() (we would've
> >> broken shrink_dcache_parent() that way), but we can do unhashing
> >> in check_and_drop() in "really nothing to do" case and we can return
> >> from d_invalidate() after that. So how about this:
> > That does the trick.
>
> I'm not entirely familiar the process here, is the above change
> committed somewhere, should I propose a patch?
Sorry, got distracted by other stuff; I'll push that today.
prev parent reply other threads:[~2017-06-15 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 0:05 Hang/soft lockup in d_invalidate with simultaneous calls Khazhismel Kumykov
2017-05-17 21:58 ` Khazhismel Kumykov
2017-05-22 18:18 ` Khazhismel Kumykov
2017-05-25 22:31 ` Khazhismel Kumykov
2017-06-03 1:12 ` Al Viro
2017-06-03 5:22 ` Khazhismel Kumykov
2017-06-03 6:20 ` Al Viro
2017-06-03 6:47 ` Khazhismel Kumykov
2017-06-12 23:00 ` Khazhismel Kumykov
2017-06-15 10:50 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615105058.GK31671@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=khazhy@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.