From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wpMqW3bzKzDqL8 for ; Thu, 15 Jun 2017 22:13:59 +1000 (AEST) Date: Thu, 15 Jun 2017 14:13:55 +0200 From: Jiri Olsa To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, acme@kernel.org, "Naveen N. Rao" , Ravi Bangoria , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] perf: libdw support for powerpc Message-ID: <20170615121355.GE24413@krava> References: <1496312681-20133-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1496312681-20133-1-git-send-email-pbonzini@redhat.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jun 01, 2017 at 12:24:41PM +0200, Paolo Bonzini wrote: > Porting PPC to libdw only needs an architecture-specific hook to move > the register state from perf to libdw. > > The ARM and x86 architectures already use libdw, and it is useful to > have as much common code for the unwinder as possible. Mark Wielaard > has contributed a frame-based unwinder to libdw, so that unwinding works > even for binaries that do not have CFI information. In addition, > libunwind is always preferred to libdw by the build machinery so this > cannot introduce regressions on machines that have both libunwind and > libdw installed. > > Cc: acme@kernel.org > Cc: Naveen N. Rao > Cc: Ravi Bangoria > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Paolo Bonzini looks good and got possitive feedback from our QE testing this Acked-by: Jiri Olsa thanks, jirka