From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Thu, 15 Jun 2017 13:16:03 +0000 Subject: Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Message-Id: <20170615131603.GZ12629@intel.com> List-Id: References: <20170613134751.29196-1-colin.king@canonical.com> <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> In-Reply-To: <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Colin King On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote: >=20 > On 13/06/2017 14:47, Colin King wrote: > > From: Colin Ian King > >=20 > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > > scope, so make it static. > >=20 > > Cleans up sparse warning: > > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > > be static?" > >=20 > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i9= 15/intel_dpll_mgr.c > > index 8e669b6254ae..2f7b0e64f628 100644 > > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct inte= l_crtc *crtc, > > return true; > > } > > =20 > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > > - struct intel_dpll_hw_state *dpll_hw_state) > > +static bool > > +cnl_ddi_dp_set_dpll_hw_state(int clock, > > + struct intel_dpll_hw_state *dpll_hw_state) > > { > > uint32_t cfgcr0; > > =20 > >=20 >=20 > Reviewed-by: Tvrtko Ursulin Thanks for the patch and review. Pushed to dinq. --=20 Ville Syrj=E4l=E4 Intel OTC -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Date: Thu, 15 Jun 2017 16:16:03 +0300 Message-ID: <20170615131603.GZ12629@intel.com> References: <20170613134751.29196-1-colin.king@canonical.com> <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Colin King List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMDI6MDM6MDVQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMTMvMDYvMjAxNyAxNDo0NywgQ29saW4gS2luZyB3cm90ZToKPiA+IEZy b206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gPiAKPiA+IFRo ZSBmdW5jdGlvbiBjbmxfZGRpX2RwX3NldF9kcGxsX2h3X3N0YXRlIGRvZXMgbm90IG5lZWQgdG8g YmUgaW4gZ2xvYmFsCj4gPiBzY29wZSwgc28gbWFrZSBpdCBzdGF0aWMuCj4gPiAKPiA+IENsZWFu cyB1cCBzcGFyc2Ugd2FybmluZzoKPiA+ICJzeW1ib2wgJ2NubF9kZGlfZHBfc2V0X2RwbGxfaHdf c3RhdGUnIHdhcyBub3QgZGVjbGFyZWQuIFNob3VsZCBpdAo+ID4gICBiZSBzdGF0aWM/Igo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwu Y29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMg fCA1ICsrKy0tCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ID4gaW5k ZXggOGU2NjliNjI1NGFlLi4yZjdiMGU2NGY2MjggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcGxsX21nci5jCj4gPiBAQCAtMjI5Miw4ICsyMjkyLDkgQEAgc3RhdGljIGJvb2wg Y25sX2RkaV9oZG1pX3BsbF9kaXZpZGVycyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAg CXJldHVybiB0cnVlOwo+ID4gICB9Cj4gPiAgIAo+ID4gLWJvb2wgY25sX2RkaV9kcF9zZXRfZHBs bF9od19zdGF0ZShpbnQgY2xvY2ssCj4gPiAtCQkJCSAgc3RydWN0IGludGVsX2RwbGxfaHdfc3Rh dGUgKmRwbGxfaHdfc3RhdGUpCj4gPiArc3RhdGljIGJvb2wKPiA+ICtjbmxfZGRpX2RwX3NldF9k cGxsX2h3X3N0YXRlKGludCBjbG9jaywKPiA+ICsJCQkgICAgIHN0cnVjdCBpbnRlbF9kcGxsX2h3 X3N0YXRlICpkcGxsX2h3X3N0YXRlKQo+ID4gICB7Cj4gPiAgIAl1aW50MzJfdCBjZmdjcjA7Cj4g PiAgIAo+ID4gCj4gCj4gUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+CgpUaGFua3MgZm9yIHRoZSBwYXRjaCBhbmQgcmV2aWV3LiBQdXNoZWQgdG8g ZGlucS4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbdFONQK (ORCPT ); Thu, 15 Jun 2017 09:16:10 -0400 Received: from mga04.intel.com ([192.55.52.120]:57111 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbdFONQI (ORCPT ); Thu, 15 Jun 2017 09:16:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,343,1493708400"; d="scan'208";a="1160847226" Date: Thu, 15 Jun 2017 16:16:03 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Tvrtko Ursulin Cc: Colin King , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Message-ID: <20170615131603.GZ12629@intel.com> References: <20170613134751.29196-1-colin.king@canonical.com> <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote: > > On 13/06/2017 14:47, Colin King wrote: > > From: Colin Ian King > > > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > > scope, so make it static. > > > > Cleans up sparse warning: > > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > > be static?" > > > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > index 8e669b6254ae..2f7b0e64f628 100644 > > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > > return true; > > } > > > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > > - struct intel_dpll_hw_state *dpll_hw_state) > > +static bool > > +cnl_ddi_dp_set_dpll_hw_state(int clock, > > + struct intel_dpll_hw_state *dpll_hw_state) > > { > > uint32_t cfgcr0; > > > > > > Reviewed-by: Tvrtko Ursulin Thanks for the patch and review. Pushed to dinq. -- Ville Syrjälä Intel OTC