From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dawid Kurek Subject: [PATCH v2] drm: Reduce scope of 'state' variable Date: Thu, 15 Jun 2017 16:04:36 +0200 Message-ID: <20170615140436.GA9939@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id D768A6E78A for ; Thu, 15 Jun 2017 14:04:44 +0000 (UTC) Received: by mail-lf0-x22b.google.com with SMTP id v20so10233296lfa.1 for ; Thu, 15 Jun 2017 07:04:44 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org U21hbGxlciBzY29wZSByZWR1Y2VzIHZpc2liaWxpdHkgb2YgdmFyaWFibGUgYW5kIG1ha2VzIHVz YWdlIG9mCnVuaW5pdGlhbGl6ZWQgdmFyaWFibGUgbGVzcyBwb3NzaWJsZS4KCkNoYW5nZXMgaW4g djI6CgktIHNlcGFyYXRlIGRlY2xhcmF0aW9uIGFuZCBpbml0aWFsaXphdGlvbgotLS0KIGRyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCmluZGV4IGYzMjUwNmEuLjVl MGQxZTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwpAQCAtMTA4LDkgKzEwOCwxMCBAQCBzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqCiBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCiB7CiAJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+bW9kZV9j b25maWc7Ci0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwogCiAJaWYgKCFjb25maWct PmZ1bmNzLT5hdG9taWNfc3RhdGVfYWxsb2MpIHsKKwkJc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlOworCiAJCXN0YXRlID0ga3phbGxvYyhzaXplb2YoKnN0YXRlKSwgR0ZQX0tFUk5FTCk7 CiAJCWlmICghc3RhdGUpCiAJCQlyZXR1cm4gTlVMTDsKLS0gCjIuMTAuMAoKCi0tLQpUaGlzIGVt YWlsIGhhcyBiZWVuIGNoZWNrZWQgZm9yIHZpcnVzZXMgYnkgQXZhc3QgYW50aXZpcnVzIHNvZnR3 YXJlLgpodHRwczovL3d3dy5hdmFzdC5jb20vYW50aXZpcnVzCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbdFOOEv (ORCPT ); Thu, 15 Jun 2017 10:04:51 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:36034 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbdFOOEt (ORCPT ); Thu, 15 Jun 2017 10:04:49 -0400 Date: Thu, 15 Jun 2017 16:04:36 +0200 From: Dawid Kurek To: Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm: Reduce scope of 'state' variable Message-ID: <20170615140436.GA9939@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-Antivirus: Avast (VPS 170615-0, 15/06/2017), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. Changes in v2: - separate declaration and initialization --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f32506a..5e0d1e1 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -108,9 +108,10 @@ struct drm_atomic_state * drm_atomic_state_alloc(struct drm_device *dev) { struct drm_mode_config *config = &dev->mode_config; - struct drm_atomic_state *state; if (!config->funcs->atomic_state_alloc) { + struct drm_atomic_state *state; + state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return NULL; -- 2.10.0 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus