All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: another 64-bit division for the host memory buffer code
Date: Thu, 15 Jun 2017 13:04:49 -0400	[thread overview]
Message-ID: <20170615170449.GD13399@localhost.localdomain> (raw)
In-Reply-To: <20170613153130.20426-1-hch@lst.de>

Looks fine.

Reviewed-by: Keith Busch <keith.busch at intel.com>

On Tue, Jun 13, 2017@05:31:30PM +0200, Christoph Hellwig wrote:
> [to be folded into "nvme-pci: implement host memory buffer support"]
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
> ---
> 
> Now tested with a full i386 build, sigh..
> ---
>  drivers/nvme/host/pci.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 788bb2c479d0..4b50fef1fa1b 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1591,12 +1591,14 @@ static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred)
>  	struct nvme_host_mem_buf_desc *descs;
>  	u32 chunk_size, max_entries, i = 0;
>  	void **bufs;
> -	u64 size;
> +	u64 size, tmp;
>  
>  	/* start big and work our way down */
>  	chunk_size = min(preferred, (u64)PAGE_SIZE << MAX_ORDER);
>  retry:
> -	max_entries = DIV_ROUND_UP(preferred, chunk_size);
> +	tmp = (preferred + chunk_size - 1);
> +	do_div(tmp, chunk_size);
> +	max_entries = tmp;
>  	descs = kcalloc(max_entries, sizeof(*descs), GFP_KERNEL);
>  	if (!descs)
>  		goto out;
> -- 
> 2.11.0
> 

      parent reply	other threads:[~2017-06-15 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 15:31 [PATCH] nvme-pci: another 64-bit division for the host memory buffer code Christoph Hellwig
2017-06-15  8:55 ` Sagi Grimberg
2017-06-15 12:10   ` Christoph Hellwig
2017-06-15 17:04 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615170449.GD13399@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.