From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dawid Kurek Subject: Re: [PATCH v2] drm: Reduce scope of 'state' variable Date: Thu, 15 Jun 2017 19:43:19 +0200 Message-ID: <20170615174319.GA8422@gmail.com> References: <20170615140436.GA9939@gmail.com> <20170615173139.fawt5c6qyyvr7qwj@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C98D6E742 for ; Thu, 15 Jun 2017 17:43:27 +0000 (UTC) Received: by mail-lf0-x236.google.com with SMTP id o83so13337162lff.3 for ; Thu, 15 Jun 2017 10:43:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170615173139.fawt5c6qyyvr7qwj@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTUvMDYvMTcsIFNlYW4gUGF1bCB3cm90ZToKPiBPbiBUaHUsIEp1biAxNSwgMjAxNyBhdCAw NDowNDozNlBNICswMjAwLCBEYXdpZCBLdXJlayB3cm90ZToKPiA+IFNtYWxsZXIgc2NvcGUgcmVk dWNlcyB2aXNpYmlsaXR5IG9mIHZhcmlhYmxlIGFuZCBtYWtlcyB1c2FnZSBvZgo+ID4gdW5pbml0 aWFsaXplZCB2YXJpYWJsZSBsZXNzIHBvc3NpYmxlLgo+ID4gCj4gPiBDaGFuZ2VzIGluIHYyOgo+ ID4gCS0gc2VwYXJhdGUgZGVjbGFyYXRpb24gYW5kIGluaXRpYWxpemF0aW9uCj4gCj4gWW91ciBw YXRjaCBpcyBtaXNzaW5nIFNpZ25lZC1vZmYtYnkgdGFnCj4gClJpZ2h0Li4uIE1pc3NlZCBpdC4g djMgb24gdGhlIHdheS4KCkRhd2lkCgotLS0KVGhpcyBlbWFpbCBoYXMgYmVlbiBjaGVja2VkIGZv ciB2aXJ1c2VzIGJ5IEF2YXN0IGFudGl2aXJ1cyBzb2Z0d2FyZS4KaHR0cHM6Ly93d3cuYXZhc3Qu Y29tL2FudGl2aXJ1cwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdFORna (ORCPT ); Thu, 15 Jun 2017 13:43:30 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36206 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbdFORn1 (ORCPT ); Thu, 15 Jun 2017 13:43:27 -0400 Date: Thu, 15 Jun 2017 19:43:19 +0200 From: Dawid Kurek To: Sean Paul Cc: Daniel Vetter , Jani Nikula , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: Reduce scope of 'state' variable Message-ID: <20170615174319.GA8422@gmail.com> References: <20170615140436.GA9939@gmail.com> <20170615173139.fawt5c6qyyvr7qwj@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615173139.fawt5c6qyyvr7qwj@art_vandelay> User-Agent: Mutt/1.7.1 (2016-10-04) X-Antivirus: Avast (VPS 170615-0, 15/06/2017), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/17, Sean Paul wrote: > On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > > Smaller scope reduces visibility of variable and makes usage of > > uninitialized variable less possible. > > > > Changes in v2: > > - separate declaration and initialization > > Your patch is missing Signed-off-by tag > Right... Missed it. v3 on the way. Dawid --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus