From: Guenter Roeck <linux@roeck-us.net>
To: sparclinux@vger.kernel.org
Subject: Re: [v1 0/2] Early boot timestamp fixes
Date: Thu, 15 Jun 2017 19:36:12 +0000 [thread overview]
Message-ID: <20170615193612.GA17525@roeck-us.net> (raw)
In-Reply-To: <1497537659-419752-1-git-send-email-pasha.tatashin@oracle.com>
On Thu, Jun 15, 2017 at 11:43:15AM -0400, Pasha Tatashin wrote:
>
>
> On 06/15/2017 11:20 AM, Guenter Roeck wrote:
> >On Thu, Jun 15, 2017 at 10:40:57AM -0400, Pavel Tatashin wrote:
> >>Guenter Roeck reported a problem that was introduced by early boot
> >>timestamp changes. Where: tick_get_frequency() returns 0.
> >>
> >>Guenter Roeck: could you please test if these patches fix the issue?
> >>
> >My tests pass with those patches applied, so
> >
> >Tested-by: Guenter Roeck <linux@roeck-us.net>
> >
> >My current sparc64 tests are
> >
> >sparc64_defconfig sun4u "TI UltraSparc IIi"
> >sparc64_defconfig sun4v "Fujitsu Sparc64 IV"
> >
> >with both SMP and non-SMP configuration variants.
> >
> >Do you happen know which CPU variants supported by qemu would test
> >all affected code branches ? Or, in other words, what would be
> >an optimal combination of CPU / machine type to test ?
>
> Hi Guenter,
>
> I have not used qemu for SPARC, so I am not fully aware of its capability.
> The changes in this work touched three types of CPUs:
>
> 1. UltraSPARC IIe (Hummingbird)
> - %stick is in I/O space, need at least to loads to get upper
> and lower part of stick value.
> 2. Spitfire
> - Use %tick and cpu frequency to determine that clock. This is
> what you tested with TI UltraSparc IIi
> 3. All other
> - use %stick register and stick-frequency values. This is what
> you tested with Fujitsu Sparc64 IV (which by the way is still
> sun4u, I do not think qemu supports sun4v emulation)
>
Oopsie :-)
Building sparc64:sun4u:TI UltraSparc IIi:smp:sparc64_defconfig ... running ..... passed
Building sparc64:sun4v:TI UltraSparc IIe:smp:sparc64_defconfig ... running ............................ failed (timeout)
------------
qemu log:
OpenBIOS for Sparc64
Configuration device id QEMU version 1 machine id 64
kernel addr 404000 size 101dd2c
kernel cmdline root=/dev/vda init=/sbin/init.sh console=ttyS0 doreboot
CPUs: 1 x SUNW,UltraSPARC-IIe
UUID: 00000000-0000-0000-0000-000000000000
Welcome to OpenBIOS v1.1 built on Nov 24 2016 21:23
Type 'help' for detailed information
[sparc64] Kernel already loaded
Unhandled Exception 0x0000000000000028
PC = 0x0000000000462234 NPC = 0x0000000000462238
Stopping execution
qemu-system-sparc64: terminating on signal 15 from pid 14226 (/bin/bash)
------------
Building sparc64:sun4v:Fujitsu Sparc64 IV:smp:sparc64_defconfig ... running ..... passed
Trying with v4.12-rc4 gives me a different crash for UltraSparc IIe:
[ 0.000000] NR_IRQS:2048 nr_irqs:2048 1
[ 0.000000] \|/ ____ \|/
[ 0.000000] "@'/ .. \`@"
[ 0.000000] /_| \__/ |_\
[ 0.000000] \__U_/
[ 0.000000] swapper/0(0): TL0: Kernel divide by zero. [#1]
[ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.12.0-rc4+ #1
[ 0.000000] task: 0000000000ae3e80 task.stack: 0000000000ad4000
[ 0.000000] TSTATE: 0000008880e01607 TPC: 0000000000b5d8a4 TNPC: 0000000000b5d8a8 Y: 00000000 Not tainted
[ 0.000000] TPC: <time_init+0xf4/0x1b8>
[ 0.000000] g0: 0000000000b4cf50 g1: 0000000000000000 g2: 000000ee6b280000 g3: 0000000000000000
[ 0.000000] g4: 0000000000ae3e80 g5: fffff8001ec5c000 g6: 0000000000ad4000 g7: 00000000ffffffff
[ 0.000000] o0: 0000000000000000 o1: 0000000000a3c1f0 o2: 0000000000000000 o3: 0000000000000000
[ 0.000000] o4: 0000000200000000 o5: 0000000000000001 sp: 0000000000ad75c1 ret_pc: 0000000000b5d824
[ 0.000000] RPC: <time_init+0x74/0x1b8>
[ 0.000000] l0: 0000000077359400 l1: 0000000000bb8c00 l2: 0000000000baf940 l3: 0000000000bb2100
[ 0.000000] l4: 0000000000bb8c00 l5: 0000000000adec00 l6: 0000000000bb2100 l7: 0000000000983898
[ 0.000000] i0: 0000000000adb400 i1: 0000000000adec00 i2: 0000000000ae5c00 i3: ffffffffffffffff
[ 0.000000] i4: 0000000000000000 i5: 0000000000a3c2b0 i6: 0000000000ad7671 i7: 0000000000b5a8a4
[ 0.000000] I7: <start_kernel+0x2b0/0x430>
[ 0.000000] Call Trace:
[ 0.000000] [0000000000b5a8a4] start_kernel+0x2b0/0x430
[ 0.000000] [00000000009777b4] tlb_fixup_done+0x4c/0x58
[ 0.000000] [00000000ffd0e444] 0xffd0e444
[ 0.000000] Disabling lock debugging due to kernel taint
[ 0.000000] Caller[0000000000b5a8a4]: start_kernel+0x2b0/0x430
[ 0.000000] Caller[00000000009777b4]: tlb_fixup_done+0x4c/0x58
Still in the timer code, though. Adding some debugging:
[ 0.000000] ############# spitfire
[ 0.000000] ############# Hummingbird
[ 0.000000] ############# stick-frequency=0
[ 0.000000] ############## time_init(): freq=0
This suggests that the stick-frequency devicetree property isn't there.
Checking the openbios source confirms it. Overall the code does not look
correct, though, since
freq = of_getintprop_default(dp, "stick-frequency", 0);
suggests that a frequency of 0 would be acceptable but isn't.
Anyway, adding "stick-frequency" to the properties provided by openbios
fixes this crash both upstream and in your code, only to result in a hang
a bit later.
[ 0.000000] clocksource: hbtick: mask: 0xffffffffffffffff max_cycles: 0x171024e7e0, max_idle_ns: 440795205315 ns
[ 0.000000] clocksource: mult[a000000] shift[24]
[ 0.000000] clockevent: mult[1999999a] shift[32]
[ 0.000000] Console: colour dummy device 80x25
[ hangs here until terminated ]
Guess that means that qemu doesn't really support this CPU,
and your code is fine.
Guenter
next prev parent reply other threads:[~2017-06-15 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 14:40 [v1 0/2] Early boot timestamp fixes Pavel Tatashin
2017-06-15 15:20 ` Guenter Roeck
2017-06-15 15:21 ` David Miller
2017-06-15 15:23 ` David Miller
2017-06-15 15:34 ` Pasha Tatashin
2017-06-15 15:43 ` Pasha Tatashin
2017-06-15 17:57 ` Mark Cave-Ayland
2017-06-15 18:06 ` David Miller
2017-06-15 19:36 ` Guenter Roeck [this message]
2017-06-15 20:01 ` Pasha Tatashin
2017-06-15 20:33 ` Guenter Roeck
2017-06-15 21:36 ` Guenter Roeck
2017-06-16 12:17 ` Mark Cave-Ayland
2017-06-16 12:23 ` Mark Cave-Ayland
2017-06-16 16:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615193612.GA17525@roeck-us.net \
--to=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.