From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dLaew-00060X-FZ for mharc-grub-devel@gnu.org; Thu, 15 Jun 2017 15:42:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLaev-0005x2-3x for grub-devel@gnu.org; Thu, 15 Jun 2017 15:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLaer-0001FI-Uj for grub-devel@gnu.org; Thu, 15 Jun 2017 15:42:25 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:36044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLaer-0001Ef-Nh for grub-devel@gnu.org; Thu, 15 Jun 2017 15:42:21 -0400 Received: by mail-pf0-x243.google.com with SMTP id y7so2760436pfd.3 for ; Thu, 15 Jun 2017 12:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3x0D3xGfiEhlyzOVYI7xLUxQWhtRkY3eetDOT9TUemI=; b=Ns+ZqlkSOgkYyqpljHUj9atH5BdU8m23GqzYPoNmJBpkY884VDBoUtcZ3f2zJRl5/U GttNuRPzMpDjFBOEupjw3xjYJtF9M3IRXLhUMoPGrvX1xVT4f9Zj8JAk79EXyWDRUKDA /qggS4irK61Xu7jb143GRquTS+QQAY1EQM+w071Pavcq86ZWZrVx8k0ZI9iMGfsbZYBV yFsfpyKYjBm243Dg3eGLzzCqE0RuY5O0Z1CGwNI5ZovfB4zwWvUFTV63UrM7lbjx+AgP yco9O93Ibu2IY4n8ozM8Igf3qxn9xu1zmpZ5sjoy58lo7rm2n83du79aLEAOCBruOrML NHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3x0D3xGfiEhlyzOVYI7xLUxQWhtRkY3eetDOT9TUemI=; b=N2pMEwBwsVQq7MJYQfEJSraJRpgWJ/j2XGIwh02Mt8Hi3YRJsiE4coMhbAgk/b2kbG bI5nxuKmzd47JicDDBqTL1xnhrR8IyfHNI/iEikp/fJ24F3AZeNLdfoYVkm277KV2GFF UbeQfjmEYSQdcSNYIDWOr0qu0/gaeQ+Qpvvmsxxle9R6xhVAYJ5NFq4gqZakSve411UM 1iKPLbj3N1QhpoIBMWrTJe2ZlkJdzOoZhca4zFoV3OO+e4pV+5SPTRDkAVWjV2y0TdAS pFLD4K4WavKiIF5RZadhxspvl/vToqHmlpLdfMt2HUOgM+/a++3D33mQbjP23DL9GoDN MVFg== X-Gm-Message-State: AKS2vOz7YrH5M4rzbjLX88EYGwNv07xGFJXy2dl6jH/hR1lcLfdEmYiJ 4TPxSJzgwphUjDSjiaM= X-Received: by 10.98.224.4 with SMTP id f4mr6827290pfh.72.1497555740605; Thu, 15 Jun 2017 12:42:20 -0700 (PDT) Received: from zzz (c-73-239-167-150.hsd1.wa.comcast.net. [73.239.167.150]) by smtp.gmail.com with ESMTPSA id e18sm131589pfk.118.2017.06.15.12.42.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Jun 2017 12:42:20 -0700 (PDT) Date: Thu, 15 Jun 2017 12:42:18 -0700 From: Eric Biggers To: The development of GNU GRUB Cc: Eric Biggers Subject: Re: [PATCH] ext2: support EXT4_FEATURE_INCOMPAT_ENCRYPT Message-ID: <20170615194218.GA581@zzz> References: <20170615053635.1756-1-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 19:42:26 -0000 Hi Vladimir, On Thu, Jun 15, 2017 at 11:12:32AM +0000, Vladimir 'phcoder' Serbinenko wrote: > Good. Thank you for doing this. Please don't mark obscure error messages > for translation (N_). In this patch no string needs translation. Would it > also be possible to add some tests? Thanks for the review; I've sent v2 which removes the N_() calls and adds an ext4_encrypt test to grub-fs-tester. One caveat is that formatting and mounting a filesystem with '-O encrypt' is only possible with e2fsprogs v1.43+ and Linux v4.1+. Perhaps those should be detected as a prerequisite? I don't think there's a good way to detect the encryption support other than trying it and seeing if it works, though. Eric