From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 6/6] nvme: track shared namespaces in a siblings list
Date: Fri, 16 Jun 2017 08:20:12 +0200 [thread overview]
Message-ID: <20170616062012.GB6592@lst.de> (raw)
In-Reply-To: <d1fe0701-6667-512e-59af-f2339ca1e52d@grimberg.me>
On Thu, Jun 15, 2017@07:49:50PM +0300, Sagi Grimberg wrote:
>> +static int nvme_ns_link_siblings(struct nvme_ns *ns, struct nvme_id_ns
>> *id,
>> + struct nvme_ns *cur)
>> +{
>
> The fact that this can also not link sibling makes me think that
> the name is a bit confusing. I'm wandering if it would be a good
> idea to split the id check (and comparison) and the actual link
> itself?
I though up that, but the ugliness is that we have three possible
outcomes: link up (success), not link up (success) or not link up (error),
which would be a bit ugly. But I could probably do it by using -errno, 0
and 1 as return values.
next prev parent reply other threads:[~2017-06-16 6:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 16:34 track subsystem relationships and shared namespaces Christoph Hellwig
2017-06-15 16:34 ` [PATCH 1/6] nvme: remove an misleading comment on strut nvme_ns Christoph Hellwig
2017-06-15 16:51 ` Sagi Grimberg
2017-06-16 8:29 ` Johannes Thumshirn
2017-06-15 16:34 ` [PATCH 2/6] nvme: read the subsystem NQN from Identify Controller Christoph Hellwig
2017-06-15 16:54 ` Sagi Grimberg
2017-06-16 8:42 ` Johannes Thumshirn
2017-06-16 8:53 ` Christoph Hellwig
2017-06-18 8:03 ` Sagi Grimberg
2017-06-15 16:34 ` [PATCH 3/6] nvme: simplify nvme_dev_attrs_are_visible Christoph Hellwig
2017-06-15 16:55 ` Sagi Grimberg
2017-06-16 8:44 ` Johannes Thumshirn
2017-06-15 16:35 ` [PATCH 4/6] nvme-fabrics: verify that a controller returns the correct NQN Christoph Hellwig
2017-06-15 16:55 ` Sagi Grimberg
2017-06-16 8:47 ` Johannes Thumshirn
2017-06-15 16:35 ` [PATCH 5/6] nvme: track subsystems Christoph Hellwig
2017-06-15 17:04 ` Sagi Grimberg
2017-06-16 6:21 ` Christoph Hellwig
2017-06-15 16:35 ` [PATCH 6/6] nvme: track shared namespaces in a siblings list Christoph Hellwig
2017-06-15 16:49 ` Sagi Grimberg
2017-06-16 6:20 ` Christoph Hellwig [this message]
2017-06-18 8:17 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2017-06-19 9:57 track subsystem relationships and shared namespaces V2 Christoph Hellwig
2017-06-19 9:57 ` [PATCH 6/6] nvme: track shared namespaces in a siblings list Christoph Hellwig
2017-06-19 10:12 ` Sagi Grimberg
2017-06-19 10:19 ` Christoph Hellwig
2017-06-19 10:39 ` Sagi Grimberg
2017-06-19 10:42 ` Christoph Hellwig
2017-06-19 10:57 ` Sagi Grimberg
2017-06-19 10:59 ` Christoph Hellwig
2017-06-19 11:27 ` Sagi Grimberg
2017-06-19 13:00 ` Christoph Hellwig
2017-06-19 16:43 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616062012.GB6592@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.