From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdFPG1k (ORCPT ); Fri, 16 Jun 2017 02:27:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48756 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdFPG1j (ORCPT ); Fri, 16 Jun 2017 02:27:39 -0400 Date: Fri, 16 Jun 2017 08:27:36 +0200 From: Greg Kroah-Hartman To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Linus Torvalds , Alan Cox , Arnd Bergmann , Linus Walleij Subject: Re: [PATCH 2/2] char_dev: order /proc/devices by major number Message-ID: <20170616062736.GD29049@kroah.com> References: <20170615200521.3399-1-logang@deltatee.com> <20170615200521.3399-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615200521.3399-2-logang@deltatee.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2017 at 02:05:21PM -0600, Logan Gunthorpe wrote: > Presently, the order of the char devices listed in /proc/devices is not > entirely sequential. If a char device has a major number greater than > CHRDEV_MAJOR_HASH_SIZE (255), it will be ordered as if its major were > module 255. For example, 511 appears after 1. Hey, nice fix, that was annoying! Also looks like block devices have the same issue in this file, care to fix that up too while you are there? :) thanks, greg k-h