All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH mmc/next v2 1/2] mmc: tmio: improve checkpatch cleanness
Date: Fri, 16 Jun 2017 11:20:10 +0200	[thread overview]
Message-ID: <20170616092010.GB6032@verge.net.au> (raw)
In-Reply-To: <20170616081445.tqlhod5znrqnxtc3@ninjato>

On Fri, Jun 16, 2017 at 10:14:45AM +0200, Wolfram Sang wrote:
> Hi Simon,
> 
> > * Don't add bogus ',' after KERN_DEBUG
> 
> Well...
> 
> > @@ -127,16 +127,17 @@ static int tmio_mmc_next_sg(struct tmio_mmc_host *host)
> >  
> >  #define STATUS_TO_TEXT(a, status, i) \
> >  	do { \
> > -		if (status & TMIO_STAT_##a) { \
> > -			if (i++) \
> > -				printk(" | "); \
> > -			printk(#a); \
> > +		if ((status) & TMIO_STAT_##a) { \
> > +			if ((i)++) \
> > +				printk(KERN_DEBUG " | "); \
> > +			printk(KERN_DEBUG, #a); \
> 
> ...still there.

Oops.

> > @@ -349,13 +350,22 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host, struct mmc_command
> >  	}
> >  
> >  	switch (mmc_resp_type(cmd)) {
> > -	case MMC_RSP_NONE: c |= RESP_NONE; break;
> > +	case MMC_RSP_NONE:
> > +		c |= RESP_NONE;
> > +		break;
> >  	case MMC_RSP_R1:
> >  	case MMC_RSP_R1_NO_CRC:
> > -			   c |= RESP_R1;   break;
> > -	case MMC_RSP_R1B:  c |= RESP_R1B;  break;
> > -	case MMC_RSP_R2:   c |= RESP_R2;   break;
> > -	case MMC_RSP_R3:   c |= RESP_R3;   break;
> > +		c |= RESP_R1;
> > +		break;
> > +	case MMC_RSP_R1B:
> > +		c |= RESP_R1B;
> > +		break;
> > +	case MMC_RSP_R2:
> > +		c |= RESP_R2;
> > +		break;
> > +	case MMC_RSP_R3:
> > +		c |= RESP_R3;
> > +		break;
> 
> Very personal, I'd prefer the old way but I don't insist.
> 
> > -			 * Disable auto CMD12 at IO_RW_EXTENDED and SET_BLOCK_COUNT
> > -			 * when doing multiple block transfer
> > +			 * Disable auto CMD12 at IO_RW_EXTENDED and
> > +			 * SET_BLOCK_COUNT when doing multiple block
> > +			 * transfer
> 
> I'd think 'transfer' can go to the previous line?
> 
> >  			if ((host->pdata->flags & TMIO_MMC_HAVE_CMD12_CTRL) &&
> > -			    (cmd->opcode == SD_IO_RW_EXTENDED || host->mrq->sbc))
> > +			    (cmd->opcode == SD_IO_RW_EXTENDED ||
> > +			     host->mrq->sbc))
> 
> Another subjective taste thingie ;)
> 
> > -		dev_warn_once(&host->pdev->dev,
> > -		      "Too many taps, skipping tuning. Please consider updating size of taps field of tmio_mmc_host\n");
> > +		dev_warn_once(&host->pdev->dev, "Too many taps, skipping tuning. Please consider updating size of taps field of tmio_mmc_host\n");
> 
> Dito.
> 
> What kind of tests did you run with these?

I checked that Lager boots and that I/O speeds are as expected using dd.

  reply	other threads:[~2017-06-16  9:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 19:00 [PATCH mmc/next v2 0/2] mmc: tmio, renesas-sdhi: cleanups Simon Horman
2017-06-15 19:00 ` [PATCH mmc/next v2 1/2] mmc: tmio: improve checkpatch cleanness Simon Horman
2017-06-16  8:14   ` Wolfram Sang
2017-06-16  9:20     ` Simon Horman [this message]
2017-06-16 15:53       ` Simon Horman
2017-06-15 19:00 ` [PATCH mmc/next v2 2/2] mmc: renesas-sdhi: " Simon Horman
2017-06-16  8:26   ` Wolfram Sang
2017-06-16  8:27 ` [PATCH mmc/next v2 0/2] mmc: tmio, renesas-sdhi: cleanups Wolfram Sang
2017-06-16  9:19   ` Simon Horman
2017-06-16  9:24     ` Simon Horman
2017-06-16  9:29       ` Wolfram Sang
2017-06-16 11:52         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616092010.GB6032@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.