From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.0.23 with SMTP id 23csp1420455lfa; Fri, 16 Jun 2017 11:51:16 -0700 (PDT) X-Received: by 10.55.137.69 with SMTP id l66mr14850388qkd.83.1497639076048; Fri, 16 Jun 2017 11:51:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497639076; cv=none; d=google.com; s=arc-20160816; b=DCasCGlu5efvnWcerL7e4/ZLmOBerFEDW6wwd8cl8+SCLHEsSZ9BELrvMwNrbDsmI8 j2ADfPMiv9wI98MqsWUzhz4frOaDMfrbEvnvPQKQUzXDizfuzB3AYwuypGwto1x6rh1z d6PMtKagV5rHOJVha5iSj3JUgHxihRos2JGAWfC/0UEktFri5kxJpykXTdvOhPTkTAFA 9cEL3csiCoedw9CSWQpjayuoiiG1EOXMCfW9Z5J1CKb1jnMmoABI3V2T0IkI2U+yIrMm IE0x/ANcHEPYey3r/nnNmqcUN9KSSzTPurMEl9BupP76r9jV5HdSuc4f/Zi0tGnEpm6L Cj1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date :dkim-signature:dkim-signature:arc-authentication-results; bh=fGXOS8PD37ACv9DSveJ/vecKbtMONJv4JrrddYlQyl8=; b=zX3elaYZbVPM44qfNFGsu9L6C/W+Xi1VlZ7wyhJGSQ512fh9xgI8uhiFALP2vyumr6 9315KKfdV7e1TsiGre4WPfia64RdoY0StIzPMfBPxH8Z/YPKXwjYV22fIhvXyreGIdQE qBWMHo9P4603vTF3NmzSj+wnL1rZY1JI6DJ8xYDUavPoHMMWSu9PN0zEMkQudtuI9wH/ SDMUIBtNK8mOhiOjMf+vs4WzNg7AKHnpEIpAKT4RtMQQwNad518XvnzOLrILhyBcbsCB ZHd17bxhR48iG/Yg3w6dyiWZOwFM+W3HDVTIs70Hx9e76f4ApAZSRv6u2pICkq3X/lR5 IC7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@braap.org header.b=RB3XXg5E; dkim=fail header.i=@messagingengine.com header.b=SaiDmNOg; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s16si2658376qks.85.2017.06.16.11.51.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 16 Jun 2017 11:51:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@braap.org header.b=RB3XXg5E; dkim=fail header.i=@messagingengine.com header.b=SaiDmNOg; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:60346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLwKv-0002cl-AI for alex.bennee@linaro.org; Fri, 16 Jun 2017 14:51:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLwKk-0002cM-Uo for qemu-arm@nongnu.org; Fri, 16 Jun 2017 14:51:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLwKh-00032B-Ne for qemu-arm@nongnu.org; Fri, 16 Jun 2017 14:51:02 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dLwKh-0002zk-6o; Fri, 16 Jun 2017 14:50:59 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3D75E2070F; Fri, 16 Jun 2017 14:50:57 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Fri, 16 Jun 2017 14:50:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=fGXOS8PD37ACv9DSveJ/vecKbtMONJv4JrrddY lQyl8=; b=RB3XXg5EoT+2C60+TPWynecQNQccI79gdXlVw+4mtLIXeBR0LwEeUT XphiWPPPhK7yqtaqC2wmC77PryMNjNPYGPoIIMGXPYYmZrSzre800Vh5CiZTQyjf SdeqtisDDr4XQABVy+nil42/nNBGFyrgWXmsgiJq+tjpJ2x6OWe/E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=fGXOS8PD37ACv9DSve J/vecKbtMONJv4JrrddYlQyl8=; b=SaiDmNOgihjzkVWgGaAOi1k9vTiqbGttpo 3XM4+5mRsC8pZyGBhf5f0CVjLWeUsNRjjN4nJarhEZbhi+BANcRj3OaNlZvNUu8V SEDPE3JvVlQJKJq64KLBpqHk0nnCnGKqE6jdTfq5bR+piirFQkm6yWECaxGsc7Zy fF4SWlUzcYzcat9LnKIVX/vuHvy22y8CCqAAnCDCsNJ/NKKFuclNiBe3J+86ra0V ggn+76se7C/7sagyYGW8GEVshIroGs098HXPcbSJ7zwkOIk8soUUvlT+RFNb9lCh 0iXoF4jQYV6tjbsGS91RNAmTwLNzTJF7V0Z7Qb2+jEhSm7lT3ioQ== X-ME-Sender: X-Sasl-enc: 9VfE5RIkvxEKiJvDPWPH0siOnTuqRrf6AiuOvcFV3CcQ 1497639056 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id DF6BD24A29; Fri, 16 Jun 2017 14:50:56 -0400 (EDT) Date: Fri, 16 Jun 2017 14:50:56 -0400 From: "Emilio G. Cota" To: Paolo Bonzini Message-ID: <20170616185056.GA3055@flamenco> References: <1497567879-13734-1-git-send-email-cota@braap.org> <1497567879-13734-2-git-send-email-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 Subject: Re: [Qemu-arm] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Guan Xuetao , =?iso-8859-1?Q?Llu=EDs?= Vilanova , Marek Vasut , Alexander Graf , Richard Henderson , Artyom Tarasenko , Eduardo Habkost , qemu-arm@nongnu.org, Yongbok Kim , Stafford Horne , David Gibson , Bastian Koppelmann , Chris Wulff , Laurent Vivier , Michael Walle , qemu-ppc@nongnu.org, Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: VoFf/+utmA86 On Fri, Jun 16, 2017 at 10:32:14 +0200, Paolo Bonzini wrote: > On 16/06/2017 01:04, Emilio G. Cota wrote: > > va = dest_gpr(ctx, ra); > > if (ctx->tb->cflags & CF_USE_ICOUNT) { > > - gen_io_start(); > > + gen_io_start(cpu_env); > > gen_helper_load_pcc(va, cpu_env); > > - gen_io_end(); > > + gen_io_start(cpu_env); > > Careful, looks like a cut-and-paste issue here. Ouch, messed up the regex there -- thanks. Fixed in the upcoming v2, which doesn't need to go through all this churn and instead takes the value from tcg_ctx as Richard pointed out. E. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLwKt-0002dh-RX for qemu-devel@nongnu.org; Fri, 16 Jun 2017 14:51:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLwKq-00039R-Ot for qemu-devel@nongnu.org; Fri, 16 Jun 2017 14:51:11 -0400 Date: Fri, 16 Jun 2017 14:50:56 -0400 From: "Emilio G. Cota" Message-ID: <20170616185056.GA3055@flamenco> References: <1497567879-13734-1-git-send-email-cota@braap.org> <1497567879-13734-2-git-send-email-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Richard Henderson , Peter Maydell , "Edgar E . Iglesias" , Eduardo Habkost , Michael Walle , Laurent Vivier , Aurelien Jarno , Yongbok Kim , Anthony Green , Chris Wulff , Marek Vasut , Stafford Horne , David Gibson , Alexander Graf , Mark Cave-Ayland , Artyom Tarasenko , Bastian Koppelmann , Guan Xuetao , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova On Fri, Jun 16, 2017 at 10:32:14 +0200, Paolo Bonzini wrote: > On 16/06/2017 01:04, Emilio G. Cota wrote: > > va = dest_gpr(ctx, ra); > > if (ctx->tb->cflags & CF_USE_ICOUNT) { > > - gen_io_start(); > > + gen_io_start(cpu_env); > > gen_helper_load_pcc(va, cpu_env); > > - gen_io_end(); > > + gen_io_start(cpu_env); > > Careful, looks like a cut-and-paste issue here. Ouch, messed up the regex there -- thanks. Fixed in the upcoming v2, which doesn't need to go through all this churn and instead takes the value from tcg_ctx as Richard pointed out. E.