Re: [PATCH] drm/i915/cnl: Add information to missing case.

[Manasi Navare <manasi.d.navare@intel.com>]

On Fri, Jun 16, 2017 at 08:58:25PM +0000, Pandiyan, Dhinakaran wrote:
> On Fri, 2017-06-16 at 13:20 -0700, Rodrigo Vivi wrote:
> > This missing case could be reached out on missing
> > type or missing voltage.
> 
> Should we even reach this far with a missing DDI type?
> 
> -DK
>

Yes it is possible that we get into this situation if reading
of the vccio voltage from PORT_COMP_DW3 returns a garbage value
due to some corruption or lets say the type is something that is not
supported on this platform.


> >  So let's add a debug
> > message to make our lives easier whenever this
> > might happen.
> > 
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index e66947a..c96c8d0 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -1802,6 +1802,7 @@ static void cnl_ddi_vswing_program(struct drm_i915_private *dev_priv,
> >  	}
> >  
> >  	if (ddi_translations == NULL) {
> > +		DRM_DEBUG_KMS("Missing DDI translation table for type %d with voltage %d\n", type, voltage);
> >  		MISSING_CASE(voltage);
> >  		return;
> >  	}

Like Paulo suggested it would be better to use a switch statement for different vccio voltages
and then have this in the default. What do you think?

Manasi


> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx