From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Date: Sat, 17 Jun 2017 07:22:12 +0200 Message-ID: <20170617052212.GA8246@lst.de> References: <149766212410.22552.15957843500156182524.stgit@dwillia2-desk3.amr.corp.intel.com> <149766212976.22552.11210067224152823950.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <149766212976.22552.11210067224152823950.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: owner-linux-mm@kvack.org To: Dan Williams Cc: akpm@linux-foundation.org, Jan Kara , linux-nvdimm@lists.01.org, linux-api@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jeff Moyer , linux-fsdevel@vger.kernel.org, Ross Zwisler , Christoph Hellwig List-Id: linux-api@vger.kernel.org On Fri, Jun 16, 2017 at 06:15:29PM -0700, Dan Williams wrote: > Refactor the core of generic_swapfile_activate() into bmap_walk() so > that it can be used by a new daxfile_activate() helper (to be added). No way in hell! generic_swapfile_activate needs to day and no new users of ->bmap over my dead body. It's a guaranteed to fuck up your data left, right and center. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbdFQFWR (ORCPT ); Sat, 17 Jun 2017 01:22:17 -0400 Received: from verein.lst.de ([213.95.11.211]:47540 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbdFQFWO (ORCPT ); Sat, 17 Jun 2017 01:22:14 -0400 Date: Sat, 17 Jun 2017 07:22:12 +0200 From: Christoph Hellwig To: Dan Williams Cc: akpm@linux-foundation.org, Jan Kara , linux-nvdimm@lists.01.org, linux-api@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jeff Moyer , linux-fsdevel@vger.kernel.org, Ross Zwisler , Christoph Hellwig Subject: Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Message-ID: <20170617052212.GA8246@lst.de> References: <149766212410.22552.15957843500156182524.stgit@dwillia2-desk3.amr.corp.intel.com> <149766212976.22552.11210067224152823950.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149766212976.22552.11210067224152823950.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2017 at 06:15:29PM -0700, Dan Williams wrote: > Refactor the core of generic_swapfile_activate() into bmap_walk() so > that it can be used by a new daxfile_activate() helper (to be added). No way in hell! generic_swapfile_activate needs to day and no new users of ->bmap over my dead body. It's a guaranteed to fuck up your data left, right and center.