From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Olga Kornievskaia <kolga@netapp.com>,
Andreas Dilger <adilger@dilger.ca>,
Olga Kornievskaia <aglo@umich.edu>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] [RFC] 64bit copy_file_range system call
Date: Sat, 17 Jun 2017 14:24:11 -0400 [thread overview]
Message-ID: <20170617182411.GA5399@fieldses.org> (raw)
In-Reply-To: <20170617150938.GA28885@infradead.org>
On Sat, Jun 17, 2017 at 08:09:38AM -0700, Christoph Hellwig wrote:
> On Sat, Jun 17, 2017 at 08:42:54AM -0400, Olga Kornievskaia wrote:
> >
> > > On Jun 17, 2017, at 6:03 AM, Christoph Hellwig <hch@infradead.org> wrote:
> > >
> > > On Fri, Jun 16, 2017 at 01:36:30PM -0400, J. Bruce Fields wrote:
> > >> It makes a difference in the clone case, doesn't it? (Though I'd think
> > >> best there would be a special "copy to end of file" value.)
> > >
> > > Clones uses a 0 length as "whole" file. Both for the NFS operation
> > > and the Linux ioctl.
> >
> > Does that actually work? There is check vfs_copy_file_range()
>
> Please re-read the above sentence. I'm talking about NFS clone and
> IOC_CLONE_RANGE, not copy_file_range. copy_file_range had to follow
> the NFS semantics that don't have the special 0 case.
Nope, COPY has it:
https://tools.ietf.org/html/rfc7862#section-15.2.3
A count of 0 (zero) requests that all bytes from ca_src_offset
through EOF be copied to the destination.
I think leaving it out of copy_file_range was just an oversight.
--b.
next prev parent reply other threads:[~2017-06-17 18:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 17:06 [PATCH 1/1] [RFC] 64bit copy_file_range system call Olga Kornievskaia
2017-06-14 17:24 ` Anna Schumaker
2017-06-14 18:53 ` Olga Kornievskaia
2017-06-14 19:32 ` Amir Goldstein
2017-06-14 20:08 ` Olga Kornievskaia
2017-06-14 21:50 ` Randy Dunlap
2017-06-15 13:07 ` Olga Kornievskaia
2017-06-15 3:59 ` Darrick J. Wong
2017-06-15 14:39 ` Olga Kornievskaia
2017-06-15 20:53 ` Darrick J. Wong
2017-06-15 20:53 ` Darrick J. Wong
2017-06-19 18:34 ` Olga Kornievskaia
2017-06-19 19:39 ` Christoph Hellwig
2017-06-19 19:48 ` Olga Kornievskaia
2017-06-20 12:38 ` Steve Dickson
2017-06-20 19:33 ` Chuck Lever
2017-06-20 19:37 ` Olga Kornievskaia
2017-06-24 11:29 ` Mkrtchyan, Tigran
2017-06-20 12:44 ` Steve Dickson
2017-06-15 8:15 ` Christoph Hellwig
2017-06-15 13:07 ` Olga Kornievskaia
2017-06-15 18:35 ` Andreas Dilger
2017-06-15 19:11 ` Olga Kornievskaia
2017-06-16 17:36 ` J. Bruce Fields
2017-06-17 10:03 ` Christoph Hellwig
2017-06-17 12:42 ` Olga Kornievskaia
2017-06-17 15:09 ` Christoph Hellwig
2017-06-17 18:24 ` J. Bruce Fields [this message]
2017-06-24 13:23 ` Jeff Layton
2017-06-26 13:21 ` Anna Schumaker
2017-06-26 13:46 ` Jeff Layton
2017-06-26 14:46 ` Olga Kornievskaia
2017-06-26 14:49 ` [PATCH 1/1] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2017-06-27 11:47 ` Jeff Layton
2017-06-27 16:12 ` Olga Kornievskaia
[not found] ` <5E53733A-8136-4FB5-A7E9-F4846BF98507@netapp.com>
2017-06-26 14:51 ` [PATCH 1/1] [RFC] 64bit copy_file_range system call Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170617182411.GA5399@fieldses.org \
--to=bfields@fieldses.org \
--cc=adilger@dilger.ca \
--cc=aglo@umich.edu \
--cc=hch@infradead.org \
--cc=kolga@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.