From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 18 Jun 2017 09:24:06 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Omar Sandoval , Paolo Valente , linux-block@vger.kernel.org Subject: Re: [PATCH 05/10] blk-mq: simplify blk_mq_free_request Message-ID: <20170618072406.GA25582@lst.de> References: <20170616161527.17649-1-hch@lst.de> <20170616161527.17649-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Sat, Jun 17, 2017 at 03:50:40PM -0600, Jens Axboe wrote: > On 06/16/2017 10:15 AM, Christoph Hellwig wrote: > > Merge three functions only tail-called by blk_mq_free_request into > > blk_mq_free_request. > > This doesn't compile, as blk_mq_merge_queue_io() has a call to > __blk_mq_finish_request(). Hmm. The tree I've based my work on certainly doesn't. But it doesn't even have blk_mq_merge_queue_io at all either, as does your for-4.13/block block tree. What am I missing?