Re: [PATCH nft v3] src: Pass stateless, numeric, ip2name and handle variables as structure members.

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Jun 16, 2017 at 02:54:06PM +0530, Varsha Rao wrote:
> libnftables library will be created soon. So declare numeric_output,
> stateless_output, ip2name_output and handle_output as members of
> structure output_ctx, instead of global variables. Rename these
> variables as following,
> 
> numeric_output -> numeric
> stateless_output -> stateless
> ip2name_output -> ip2name
> handle_output -> handle
> 
> Also add struct output_ctx *octx as member of struct netlink_ctx.

Applied, thanks Varsha. Some small changes though, see below.

> diff --git a/src/main.c b/src/main.c
> index 5089ff2..d09fd78 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -28,11 +28,8 @@
>  #include <iface.h>
>  #include <cli.h>
>  
> +struct output_ctx octx;

I turned this into 'static struct ...'

>  unsigned int max_errors = 10;
> -unsigned int numeric_output;
> -unsigned int stateless_output;
> -unsigned int ip2name_output;
> -unsigned int handle_output;
>  #ifdef DEBUG
>  unsigned int debug_level;
>  #endif
[...]

And some other small comestic changes, but overall looks good!

Thanks!