All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Bart Van Assche <bart.vanassche@sandisk.com>
Subject: Re: [PATCH v5 00/12] blk-mq: fix & improve queue quiescing
Date: Sun, 18 Jun 2017 14:26:05 -0600	[thread overview]
Message-ID: <20170618202604.GA14417@kernel.dk> (raw)
In-Reply-To: <20170613021518.GB15043@ming.t460p>

On Tue, Jun 13 2017, Ming Lei wrote:
> On Tue, Jun 06, 2017 at 10:03:12AM -0600, Jens Axboe wrote:
> > On 06/06/2017 09:21 AM, Ming Lei wrote:
> > > Hi,
> > > 
> > > There is one big issue in current blk_mq_quiesce_queue():
> > > 
> > >     - in case of direct issue or BLK_MQ_S_START_ON_RUN, dispatch won't
> > >     be prevented after blk_mq_quiesce_queue() is returned.
> > > 
> > > 
> > > The 1st two patches fix two problems in direct issue, please consider
> > > it for v4.12.
> > > 
> > > The other 10 patches improves blk_mq_quiesce_queue(), and
> > > make is easy to use, and avoid race between queue restart and
> > > quiescing. These 10 patches should be for v4.13.
> > 
> > I've added 1-2 for 4.12, I'll review the rest for 4.13 when some
> > cycles free up.
> 
> Hi Jens,
> 
> If you are fine with 3-12, could you consider it for v4.13?
> 
> The fixes on uses of blk_mq_tagset_busy_iter() depends on
> this patchset.

Yes, I think it looks fine. I've applied the rest, except the nvme
patch, which no longer applies since start/stop changes have been made
there. Please resend that one against for-4.13/block, thanks.

-- 
Jens Axboe

  reply	other threads:[~2017-06-18 20:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 15:21 [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Ming Lei
2017-06-06 15:21 ` [PATCH v5 01/12] blk-mq: pass correct hctx to blk_mq_try_issue_directly Ming Lei
2017-06-06 15:59   ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 02/12] blk-mq: fix direct issue Ming Lei
2017-06-06 16:02   ` Bart Van Assche
2017-06-06 16:02     ` Bart Van Assche
2017-06-07  2:50     ` Ming Lei
2017-06-06 15:22 ` [PATCH v5 03/12] blk-mq: move blk_mq_quiesce_queue() into include/linux/blk-mq.h Ming Lei
2017-06-06 16:06   ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 04/12] blk-mq: introduce blk_mq_quiesce_queue_nowait() Ming Lei
2017-06-06 15:22 ` [PATCH v5 05/12] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-06-06 15:22 ` [PATCH v5 06/12] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-06-06 15:22   ` Ming Lei
2017-06-06 15:22 ` [PATCH v5 07/12] nvme: host: unquiesce queue in nvme_kill_queues() Ming Lei
2017-06-06 15:22   ` Ming Lei
2017-06-06 15:22 ` [PATCH v5 08/12] blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue Ming Lei
2017-06-06 16:03   ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 09/12] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-06-06 15:22 ` [PATCH v5 10/12] blk-mq: don't stop queue for quiescing Ming Lei
2017-06-06 15:22 ` [PATCH v5 11/12] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-06-06 16:07   ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 12/12] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-06-06 16:03 ` [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Jens Axboe
2017-06-13  2:15   ` Ming Lei
2017-06-18 20:26     ` Jens Axboe [this message]
2017-06-18 23:05       ` Bart Van Assche
2017-06-18 23:48         ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2017-06-06 15:20 Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618202604.GA14417@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bart.vanassche@sandisk.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.