From: Greg KH <gregkh@linuxfoundation.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: stable@vger.kernel.org, honclo@linux.vnet.ibm.com
Subject: Re: [PATCH] vTPM: Fix missing NULL check
Date: Mon, 19 Jun 2017 09:11:17 +0800 [thread overview]
Message-ID: <20170619011117.GA2657@kroah.com> (raw)
In-Reply-To: <20170618234321.21846-1-jarkko.sakkinen@linux.intel.com>
On Mon, Jun 19, 2017 at 01:43:21AM +0200, Jarkko Sakkinen wrote:
> From: "Hon Ching \\(Vicky\\) Lo" <honclo@linux.vnet.ibm.com>
>
> The current code passes the address of tpm_chip as the argument to
> dev_get_drvdata() without prior NULL check in
> tpm_ibmvtpm_get_desired_dma. This resulted an oops during kernel
> boot when vTPM is enabled in Power partition configured in active
> memory sharing mode.
>
> The vio_driver's get_desired_dma() is called before the probe(), which
> for vtpm is tpm_ibmvtpm_probe, and it's this latter function that
> initializes the driver and set data. Attempting to get data before
> the probe() caused the problem.
>
> This patch adds a NULL check to the tpm_ibmvtpm_get_desired_dma.
>
> fixes: 9e0d39d8a6a0 ("tpm: Remove useless priv field in struct tpm_vendor_specific")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
> Reviewed-by: Jarkko Sakkine <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
> Backport for v4.9. I asked to Vicky to test my backport so this should be OK.
Thanks for this, but next time can you give me a hint of what the git
commit id is for the patch in Linus's tree? I had to go dig it out by
hand :(
greg k-h
next prev parent reply other threads:[~2017-06-19 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 23:43 [PATCH] vTPM: Fix missing NULL check Jarkko Sakkinen
2017-06-19 1:11 ` Greg KH [this message]
2017-06-19 14:37 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2017-03-06 22:32 Hon Ching(Vicky) Lo
2017-03-06 22:32 ` Hon Ching(Vicky) Lo
[not found] ` <1488839535-11822-1-git-send-email-honclo-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-03-06 23:19 ` Jason Gunthorpe
[not found] ` <20170306231946.GA23953-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-08 4:12 ` Hon Ching(Vicky) Lo
[not found] ` <1488946363.15595.17.camel-0wQ8x0XRVuT1ENwx4SLHqw@public.gmane.org>
2017-03-08 17:17 ` Jason Gunthorpe
2017-03-08 20:28 ` [tpmdd-devel] " Hon Ching(Vicky) Lo
[not found] ` <1489004891.15595.37.camel-0wQ8x0XRVuT1ENwx4SLHqw@public.gmane.org>
2017-03-08 20:52 ` Jason Gunthorpe
2017-03-06 22:21 Hon Ching(Vicky) Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619011117.GA2657@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=honclo@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.