From: Johannes Thumshirn <jthumshirn@suse.de>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
giridhar.malaval@cavium.com, darren.trapp@cavium.com
Subject: Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling
Date: Mon, 19 Jun 2017 10:09:11 +0200 [thread overview]
Message-ID: <20170619080910.GA3752@linux-x5ow.site> (raw)
In-Reply-To: <20170616224744.3681-2-himanshu.madhani@cavium.com>
On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote:
> From: Duane Grigsby <duane.grigsby@cavium.com>
>
> Signed-off-by: Darren Trapp <darren.trapp@cavium.com>
> Signed-off-by: Duane Grigsby <duane.grigsby@cavium.com>
> Signed-off-by: Anil Gurumurthy <anil.gurumurhty@cavium.com>
> Signed-off-by: Giridhar Malavali <giridhar.malavali@cavium.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
> ---
[...]
> +
> + if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) ||
> + (fcport->fw_login_state == DSC_LS_PLOGI_COMP) ||
> + (fcport->fw_login_state == DSC_LS_PRLI_PEND))
> + return rval;
Minor nit, superfluous parenthesis.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-19 8:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 22:47 [PATCH 0/6] qla2xxx: Add NVMe FC Fabric support in driver Himanshu Madhani
2017-06-16 22:47 ` [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling Himanshu Madhani
2017-06-19 8:09 ` Johannes Thumshirn [this message]
2017-06-19 16:37 ` Madhani, Himanshu
2017-06-19 20:26 ` James Smart
2017-06-20 4:27 ` Madhani, Himanshu
2017-06-16 22:47 ` [PATCH 2/6] qla2xxx: Add FC-NVMe command handling Himanshu Madhani
2017-06-19 8:20 ` Johannes Thumshirn
2017-06-19 16:37 ` Madhani, Himanshu
2017-06-19 21:01 ` James Smart
2017-06-20 4:29 ` Madhani, Himanshu
2017-06-16 22:47 ` [PATCH 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration Himanshu Madhani
2017-06-19 10:01 ` Johannes Thumshirn
2017-06-19 18:52 ` Madhani, Himanshu
2017-06-19 21:22 ` James Smart
2017-06-20 4:31 ` Madhani, Himanshu
2017-06-16 22:47 ` [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server Himanshu Madhani
2017-06-19 10:06 ` Johannes Thumshirn
2017-06-20 22:13 ` Madhani, Himanshu
2017-06-21 7:07 ` Johannes Thumshirn
2017-06-21 14:05 ` Madhani, Himanshu
2017-06-19 21:23 ` James Smart
2017-06-16 22:47 ` [PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration Himanshu Madhani
2017-06-19 10:08 ` Johannes Thumshirn
2017-06-19 21:24 ` James Smart
2017-06-16 22:47 ` [PATCH 6/6] qla2xxx: Update Driver version to 10.00.00.00-k Himanshu Madhani
2017-06-19 10:08 ` Johannes Thumshirn
2017-06-19 21:24 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619080910.GA3752@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=darren.trapp@cavium.com \
--cc=giridhar.malaval@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.