All of lore.kernel.org
 help / color / mirror / Atom feed
From: romeusmeister@gmail.com (Roman Storozhenko)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Is there any way to add an attribute under sysfs at the “platform” level?
Date: Mon, 19 Jun 2017 18:09:28 +0300	[thread overview]
Message-ID: <20170619150928.GA7788@home> (raw)
In-Reply-To: <20170619005522.GB995@kroah.com>

On Mon, Jun 19, 2017 at 08:55:22AM +0800, Greg KH wrote:
> On Sun, Jun 18, 2017 at 05:38:36PM +0300, Roman Storozhenko wrote:
> > Hello everybody!
> > 
> > I am trying to modify "pcspkr" driver undere linux kernel source tree. I added a new line there:
> > 
> > sample_id_dir = kobject_create_and_add("devices/platform/pcspkr/sample", NULL);
> 
> Ick, really?  What are you trying to do with "raw" kobjects?

I am trying to add "read/write" attribute under
"devices/platform/pcspkr". Just for educational purposes. Didn't find another way to do it.

> 
> > It works and creates kobject without errors. I checked this in the driver code and in the dmesg output. But "sample" catalog isn't appear under "/sys/devices/platform/pcspkr/".
> 
> Are you sure?  Odds are you really did create a kobject with that name,
> but note, the name will have '/' characters in it :)
> 
> If you want a kobject in a specific directory, you have to give it the
> parent kobject directory directly, you can not give a "path" to the
> kobject name, sorry, that's not how it works.
> 
> The kobject documentation should help you out here, have you read it?
> 
> good luck!

I have read documentation about sysfs and kobject. Now I am going to
re-read it again.

Thanks, Greg.
> 
> greg k-h

  reply	other threads:[~2017-06-19 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 14:38 Is there any way to add an attribute under sysfs at the “platform” level? Roman Storozhenko
2017-06-19  0:55 ` Greg KH
2017-06-19 15:09   ` Roman Storozhenko [this message]
2017-06-19 15:25     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619150928.GA7788@home \
    --to=romeusmeister@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.