Re: [PATCH nf] netfilter: nf_ct_dccp/sctp: fix memory leak after netns cleanup

[Florian Westphal <fw@strlen.de>]

Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
> 
> After running the following commands for a while, kmemleak reported that
> "1879 new suspected memory leaks" happened:
>   # while : ; do
>   ip netns add test
>   ip netns delete test
>   done

Acked-by: Florian Westphal <fw@strlen.de>

I think we might want to add this to nf-next:

@@ -408,8 +410,10 @@ int nf_ct_l4proto_pernet_register_one(struct net *net,
	pn = nf_ct_l4proto_net(net, l4proto);
-       if (pn == NULL)
+       if (pn == NULL) {
+               ret = -EINVAL;
		goto out;
+	}

so that nf_ct_l4proto_pernet_register_one() will return failure.

Maybe even add a WARN_ON in nf_ct_l4proto_net() to catch this.