From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v2 3/4] nvme-pci: factor out the cqe reading mechanics from __nvme_process_cq
Date: Mon, 19 Jun 2017 12:19:53 -0400 [thread overview]
Message-ID: <20170619161953.GD21765@localhost.localdomain> (raw)
In-Reply-To: <1497796090-14808-4-git-send-email-sagi@grimberg.me>
On Sun, Jun 18, 2017@05:28:09PM +0300, Sagi Grimberg wrote:
> Also, maintain a consumed counter to rely on for doorbell and
> cqe_seen update instead of directly relying on the cq head and phase.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Looks like this particular change failed to produce the best diff. :)
> - nvme_ring_cq_doorbell(nvmeq);
> + if (tag && *tag == cqe.command_id) {
> + *tag = -1;
> + break;
This 'break' is new. We're already holding the lock, why wouldn't we
want to reap all the completions?
next prev parent reply other threads:[~2017-06-19 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 14:28 [PATCH v2 0/4] refactor nvme-pci cq processing Sagi Grimberg
2017-06-18 14:28 ` [PATCH v2 1/4] nvme-pci: Introduce nvme_ring_cq_doorbell Sagi Grimberg
2017-06-19 7:01 ` Christoph Hellwig
2017-06-19 16:11 ` Keith Busch
2017-06-18 14:28 ` [PATCH v2 2/4] nvme-pci: factor out cqe handling into a dedicated routine Sagi Grimberg
2017-06-19 7:01 ` Christoph Hellwig
2017-06-19 16:12 ` Keith Busch
2017-06-18 14:28 ` [PATCH v2 3/4] nvme-pci: factor out the cqe reading mechanics from __nvme_process_cq Sagi Grimberg
2017-06-19 7:04 ` Christoph Hellwig
2017-06-19 16:19 ` Keith Busch [this message]
2017-06-19 16:32 ` Sagi Grimberg
2017-06-18 14:28 ` [PATCH v2 4/4] nvme-pci: open-code polling logic in nvme_poll Sagi Grimberg
2017-06-19 7:05 ` Christoph Hellwig
2017-06-19 16:32 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619161953.GD21765@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.