From: Al Viro <viro@ZenIV.linux.org.uk>
To: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: __user with scalar data types
Date: Mon, 19 Jun 2017 17:34:38 +0100 [thread overview]
Message-ID: <20170619163438.GE10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170619161509.GA25997@jcrouse-lnx.qualcomm.com>
On Mon, Jun 19, 2017 at 10:15:09AM -0600, Jordan Crouse wrote:
> Which raised a bikeshed debate over whether it is appropriate to mark a scalar
> type as __user. My opinion is that it is appropriate because __user should mark
> user memory regardless of the container.
What the hell? __user is a qualifier like const, volatile, etc. It's a property
of *pointer* *type*. Not some nebulous "marks userland memory" thing.
> I'm looking for opinions or semi-authoritative edicts to determine if we should
> either start changing our uapi headers or go off and try to figure out how to
> make sparse understand this particular usage.
Stop cargo-culting, please.
next prev parent reply other threads:[~2017-06-19 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 16:15 __user with scalar data types Jordan Crouse
2017-06-19 16:34 ` Al Viro [this message]
2017-06-20 7:12 ` Daniel Vetter
2017-06-20 7:12 ` Daniel Vetter
2017-06-20 7:42 ` Gerd Hoffmann
2017-06-20 7:42 ` Gerd Hoffmann
2017-06-20 8:37 ` Daniel Vetter
2017-06-20 8:37 ` Daniel Vetter
2017-06-19 19:27 ` Luc Van Oostenryck
2017-06-19 20:32 ` Luc Van Oostenryck
2017-06-19 20:46 ` Al Viro
2017-06-19 22:39 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619163438.GE10672@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.