From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
mingo@infradead.org, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate
Date: Mon, 19 Jun 2017 16:13:30 -0300 [thread overview]
Message-ID: <20170619191330.GC13640@kernel.org> (raw)
In-Reply-To: <20170619173529.GM3645@kernel.org>
Em Mon, Jun 19, 2017 at 02:35:29PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu:
>
> Marker always there, not just when we have the cursor on top of one of
> those lines remains to be coded.
>
> But you state:
>
> ------------
> Macro fusion merges two instructions to a single micro-op. Intel core
> platform performs this hardware optimization under limited
> circumstances.
> ------------
>
> "Intel core", what about older arches, etc, don't you have to look at:
>
> # cpudesc : Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz
> # cpuid : GenuineIntel,6,61,4
>
> present in the perf.data header (or in the running system, for things
> like 'perf top') to make sure that this is a machine where such "macro
> fusion" takes place?
Ok, I have the patches that need this discussion to get to a conclusion
on a separate patch, tmp.perf/annotate, the first patch, the one that
returns the 'struct arch' for the browser to use arch specific stuff is
in perf/core and can go to Ingo now.
- Arnaldo
next prev parent reply other threads:[~2017-06-19 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 2:55 [PATCH v2 0/3] perf report: Implement visual marker for macro fusion in annotate Jin Yao
2017-06-19 2:55 ` [PATCH v2 1/3] perf util: Return arch from symbol__disassemble and save it in browser Jin Yao
2017-06-20 9:02 ` [tip:perf/core] perf annotate: Return arch from symbol__disassemble() " tip-bot for Jin Yao
2017-06-19 2:55 ` [PATCH v2 2/3] perf util: Check for fused instruction Jin Yao
2017-06-19 2:55 ` [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate Jin Yao
2017-06-19 17:35 ` Arnaldo Carvalho de Melo
2017-06-19 19:13 ` Arnaldo Carvalho de Melo [this message]
2017-06-20 1:25 ` Jin, Yao
2017-06-20 1:37 ` Arnaldo Carvalho de Melo
2017-06-20 1:54 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619191330.GC13640@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@infradead.org \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.