From: Al Viro <viro@ZenIV.linux.org.uk>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls
Date: Mon, 19 Jun 2017 22:12:58 +0100 [thread overview]
Message-ID: <20170619211258.GK10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CABeXuvpKiY+BrYF3nDxkgiWMd12V=fWVydCvftsqO61yKXPKuA@mail.gmail.com>
On Mon, Jun 19, 2017 at 01:52:05PM -0700, Deepa Dinamani wrote:
> On Mon, Jun 19, 2017 at 12:46 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > On Mon, Jun 19, 2017 at 12:31:00PM -0700, Deepa Dinamani wrote:
> >
> >> 3. I was also aiming for user pointers to be not touched by timer
> >> specific code as it can get messy if not handled properly with 2
> >> compat time_t versions.
> >
> > So have one helper that deals with all copyout and have it used by
> > all of them. IMO all that code should treat userland representation
> > as completely opaque. Just switch nanosleep_copyout() to take
> > timespec64 instead of timespec (for kernel-side object) and that'll
> > do it, wouldn't it?
>
> Yes, that would work.
> If that is preferred, then I will just do that and rebase the patches.
Please, do. Note that quite a few things in that series won't be needed
anymore (e.g. compat syscalls are already moved to native ones, etc.).
Might make sense to take it to #kernel - lower latency that way...
prev parent reply other threads:[~2017-06-19 21:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 6:45 [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Deepa Dinamani
2017-06-19 6:45 ` [PATCH 1/8] time: add get_timespec64 and put_timespec64 Deepa Dinamani
2017-06-19 6:45 ` [PATCH 2/8] nanosleep: Move native and compat syscalls Deepa Dinamani
2017-06-19 6:45 ` [PATCH 3/8] kernel: compat: Move clock and timer " Deepa Dinamani
2017-06-19 6:45 ` [PATCH 4/8] nanosleep: Use get_timespec64() and set_timespec64() Deepa Dinamani
2017-06-19 6:45 ` [PATCH 5/8] posix-timers: Use get_timepsec64() and put_timespec64() Deepa Dinamani
2017-06-19 6:45 ` [PATCH 6/8] time: introduce {get,put}_itimerspec64 Deepa Dinamani
2017-06-19 6:45 ` [PATCH 7/8] posix_clocks: Use get_itimerspec64() and put_itimerspec64() Deepa Dinamani
2017-06-19 6:45 ` [PATCH 8/8] timerfd: " Deepa Dinamani
2017-06-19 7:25 ` [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Al Viro
2017-06-19 19:31 ` Deepa Dinamani
2017-06-19 19:46 ` Al Viro
2017-06-19 20:52 ` Deepa Dinamani
2017-06-19 21:12 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619211258.GK10672@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.