From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Jessica Yu <jeyu@redhat.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions
Date: Tue, 20 Jun 2017 08:45:39 +0200 [thread overview]
Message-ID: <20170620064539.GA12930@Red> (raw)
In-Reply-To: <20170619162622.7hbxm6k53f43nooh@redbean>
On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
> +++ Corentin Labbe [06/06/17 14:17 +0200]:
> >This patch just swap del_usage_link() before add_usage_link().
> >
> >Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Could you combine this with the 2nd patch? By itself this patch
> doesn't tell us much. Additionally, could you explain in the changelog
> (of the 2nd patch) why they needed to be swapped (i.e., so
> del_usage_links() can be called from add_usage_links()).
>
> Thanks!
>
> Jessica
>
I think that its against the rule of atomic/simple patch.
Perhaps, the first patch miss some "why I do it"
Anyway I will send a new version as you requested
Regards
next prev parent reply other threads:[~2017-06-20 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 12:17 [PATCH v2 0/2] suppress warning about unused nowarn variable Corentin Labbe
2017-06-06 12:17 ` [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions Corentin Labbe
2017-06-19 16:26 ` Jessica Yu
2017-06-20 6:45 ` Corentin Labbe [this message]
2017-06-26 13:37 ` Jessica Yu
2017-06-06 12:17 ` [PATCH v2 2/2] kernel/module.c: suppress warning about unused nowarn variable Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620064539.GA12930@Red \
--to=clabbe.montjoie@gmail.com \
--cc=jeyu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.