Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[Jisheng Zhang <jszhang@marvell.com>]

On Mon, 12 Jun 2017 13:05:30 +0800 Jisheng Zhang wrote:

> On Fri, 9 Jun 2017 11:26:19 +0200 Linus Walleij wrote:
> 
> > 
> > On Fri, Jun 2, 2017 at 1:27 AM,  <xgchenshy@gmail.com> wrote:  
> > > From: Xiaoguang Chen <xgchenshy@gmail.com>
> > >
> > > dwapb_irq_set_type overwrites polarity register value for
> > > IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> > > by default, then it will set falling edge irq trigger.
> > > and the gpio may requires rising edge irq for the first time,
> > > and it will be missed.
> > >
> > > Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> > > can solve this issue.  
> 
> I think this is a correct fix.
> 
> > >
> > > Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>  
> 
> Tested-by: Jisheng Zhang <jszhang@marvell.com>

Per my test, this patch fixes the following bug:

make use of CD-GPIO mechanism. Cold boot with sdcard inserted, hot-unplug
the sdcard, sometimes, kernel won't get the remove interrupt.

Thanks