From: Oleg Nesterov <oleg@redhat.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-sparse@vger.kernel.org, Chris Li <sparse@chrisli.org>
Subject: Re: [PATCH] dissect: use built_in_ident() instead of MK_IDENT()
Date: Tue, 20 Jun 2017 13:17:41 +0200 [thread overview]
Message-ID: <20170620111740.GB21354@redhat.com> (raw)
In-Reply-To: <20170619211454.45244-1-luc.vanoostenryck@gmail.com>
On 06/19, Luc Van Oostenryck wrote:
>
> The motivation for this patch was to allow sparse to be
> compiled with clang which doesn't like what is done
> on VLAs in the MK_IDENT() macro.
could you spell please? I don't understand why clang can't compile this
code and I am just curious.
> But also, I can't see any justification for not using the
> real thing to create identifiers: built_in_ident().
Simply because MK_IDENT() is faster and simpler to use.
> CC: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> dissect.h | 13 -------------
> test-dissect.c | 6 +++---
iirc there should be another MK_IDENT user in dissect.c?
Oleg.
next prev parent reply other threads:[~2017-06-20 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 21:14 [PATCH] dissect: use built_in_ident() instead of MK_IDENT() Luc Van Oostenryck
2017-06-19 22:35 ` Ramsay Jones
2017-06-19 22:42 ` Luc Van Oostenryck
2017-06-20 11:17 ` Oleg Nesterov [this message]
2017-06-20 12:53 ` Luc Van Oostenryck
2017-06-20 16:07 ` Oleg Nesterov
2017-06-20 16:39 ` Luc Van Oostenryck
2017-06-20 16:56 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620111740.GB21354@redhat.com \
--to=oleg@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.