From: Miroslav Lichvar <mlichvar@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: protect TX timestamping from API misuse
Date: Tue, 20 Jun 2017 14:55:52 +0200 [thread overview]
Message-ID: <20170620125552.GB10520@localhost> (raw)
In-Reply-To: <20170619203043.120598-1-cspradlin@google.com>
On Mon, Jun 19, 2017 at 01:30:43PM -0700, Cliff Spradlin wrote:
> HW timestamping can only be requested for a packet if the NIC is first
> setup via ioctl(SIOCSHWTSTAMP). If this step was skipped, then the igb
> driver still allowed TX packets to request HW timestamping. In this
> situation, the _IGB_PTP_TX_IN_PROGRESS flag was set and would never
> clear. This prevented any future HW timestamping requests to succeed.
Good catch!
This probably explains some weird cases I saw where HW timestamping
stopped working and the only thing that fixed it was to rmmod &&
modprobe the igb driver. I suspected a faulty HW and it's probably
just me messing with hwstamp_ctl at wrong time.
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2017-06-20 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 20:30 [Intel-wired-lan] [PATCH] igb: protect TX timestamping from API misuse Cliff Spradlin
2017-06-20 12:55 ` Miroslav Lichvar [this message]
2017-06-27 0:53 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620125552.GB10520@localhost \
--to=mlichvar@redhat.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.