From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Tue, 20 Jun 2017 15:06:52 +0000 Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Message-Id: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> List-Id: References: <20170620102202.7132-1-colin.king@canonical.com> In-Reply-To: <20170620102202.7132-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer ilb_base_addr does not need to be in global scope, so make > it static. > > Cleans up sparse warning: > "symbol 'ilb_base_addr' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King Thanks Colin. Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 506e62ca3576..c915d65c1909 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev) > #define LPC_CNTRL_REG_OFFSET 0x84 > #define LPC_CLKRUN_EN (1 << 2) > > -void __iomem *ilb_base_addr; > +static void __iomem *ilb_base_addr; > > static inline bool is_bsw(void) > { > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Date: Tue, 20 Jun 2017 17:06:52 +0200 Message-ID: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> References: <20170620102202.7132-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170620102202.7132-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Colin King Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer ilb_base_addr does not need to be in global scope, so make > it static. > > Cleans up sparse warning: > "symbol 'ilb_base_addr' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King Thanks Colin. Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 506e62ca3576..c915d65c1909 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev) > #define LPC_CNTRL_REG_OFFSET 0x84 > #define LPC_CLKRUN_EN (1 << 2) > > -void __iomem *ilb_base_addr; > +static void __iomem *ilb_base_addr; > > static inline bool is_bsw(void) > { > -- > 2.11.0 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751640AbdFTPHC (ORCPT ); Tue, 20 Jun 2017 11:07:02 -0400 Received: from mga02.intel.com ([134.134.136.20]:11866 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbdFTPHB (ORCPT ); Tue, 20 Jun 2017 11:07:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,364,1493708400"; d="scan'208";a="116649000" Date: Tue, 20 Jun 2017 17:06:52 +0200 From: Jarkko Sakkinen To: Colin King Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Message-ID: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> References: <20170620102202.7132-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620102202.7132-1-colin.king@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer ilb_base_addr does not need to be in global scope, so make > it static. > > Cleans up sparse warning: > "symbol 'ilb_base_addr' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King Thanks Colin. Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 506e62ca3576..c915d65c1909 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev) > #define LPC_CNTRL_REG_OFFSET 0x84 > #define LPC_CLKRUN_EN (1 << 2) > > -void __iomem *ilb_base_addr; > +static void __iomem *ilb_base_addr; > > static inline bool is_bsw(void) > { > -- > 2.11.0 >