From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, agruenba@redhat.com
Subject: Re: [PATCH 1/2] xfs: rewrite xfs_dq_get_next_id using xfs_iext_lookup_extent
Date: Tue, 20 Jun 2017 22:31:41 +0200 [thread overview]
Message-ID: <20170620203141.GA578@lst.de> (raw)
In-Reply-To: <4c3c78ed-9fd3-7b37-65f8-8256a98be951@sandeen.net>
On Tue, Jun 20, 2017 at 03:17:59PM -0500, Eric Sandeen wrote:
> On 6/20/17 4:02 AM, Christoph Hellwig wrote:
> > This goes straight to a single lookup in the extent list and avoids a
> > roundtrip through two layers that don't add any value for the simple
> > quoata file that just has data or holes and no page cache, delayed
> > allocation, unwritten extent or COW fork (which btw, doesn't seem to
> > be handled by the existing SEEK HOLE/DATA code).
>
> ok well that's a bit embarrassing for the original author. :D
>
> Much nicer, thanks. I assume it passes the couple of xfstests that stress this?
Both of them.. (generic/244 and generic/400)
next prev parent reply other threads:[~2017-06-20 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 9:02 simplify the Q_GETNEXTQUOTA implementation Christoph Hellwig
2017-06-20 9:02 ` [PATCH 1/2] xfs: rewrite xfs_dq_get_next_id using xfs_iext_lookup_extent Christoph Hellwig
2017-06-20 19:51 ` Darrick J. Wong
2017-06-20 20:17 ` Eric Sandeen
2017-06-20 20:31 ` Christoph Hellwig [this message]
2017-06-20 9:02 ` [PATCH 2/2] xfs: remove a whitespace-only line from xfs_fs_get_nextdqblk Christoph Hellwig
2017-06-20 20:20 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620203141.GA578@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.