From: Leon Romanovsky <leon@kernel.org>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Yuval.Mintz@cavium.com,
Linux Netdev List <netdev@vger.kernel.org>,
Michal.Kalderon@cavium.com,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP
Date: Wed, 21 Jun 2017 13:10:18 +0300 [thread overview]
Message-ID: <20170621101018.GD1248@mtr-leonro.local> (raw)
In-Reply-To: <CAJ3xEMhVdmpiGxBb8r0Sx3g_4ej7uhaCf4+qSi3ObMJ=-4ybXQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
On Wed, Jun 21, 2017 at 12:57:36PM +0300, Or Gerlitz wrote:
> On Wed, Jun 21, 2017 at 12:56 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> > On Tue, Jun 20, 2017 at 7:35 PM, David Miller <davem@davemloft.net> wrote:
> >> From: Yuval Mintz <Yuval.Mintz@cavium.com>
> >> Date: Tue, 20 Jun 2017 15:59:59 +0300
> >>
> >>> Please consider applying this series to `net-next'.
> >>
> >> Series applied, thanks.
>
> Yuval,
>
> It's broke my build
>
> In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
> from drivers/net/ethernet/qlogic/qede/qede_ethtool.c:41:
> ./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
> before '{' token
> In file included from drivers/net/ethernet/qlogic/qede/qede.h:43,
> from drivers/net/ethernet/qlogic/qede/qede_dcbnl.c:13:
> ./include/linux/qed/qede_rdma.h:85: error: expected identifier or '('
> before '{' token
> make[5]: *** [drivers/net/ethernet/qlogic/qede/qede_dcbnl.o] Error 1
>
> here's the fix
>
> diff --git a/include/linux/qed/qede_rdma.h b/include/linux/qed/qede_rdma.h
> index 1348a16..9904617 100644
> --- a/include/linux/qed/qede_rdma.h
> +++ b/include/linux/qed/qede_rdma.h
> @@ -81,7 +81,7 @@ void qede_rdma_dev_remove(struct qede_dev *dev);
> void qede_rdma_event_changeaddr(struct qede_dev *edr);
>
> #else
> -static inline int qede_rdma_dev_add(struct qede_dev *dev);
> +static inline int qede_rdma_dev_add(struct qede_dev *dev)
> {
> return 0;
> }
Yeah, Yuval sent it already:
https://patchwork.ozlabs.org/patch/778632/
Thanks
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-06-21 10:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 12:59 [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP Yuval Mintz
2017-06-20 12:59 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 2/7] qed: RoCE EDPM to honor PFC Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
[not found] ` <20170620130006.307-1-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-20 13:00 ` [PATCH v4 net-next 1/7] qed: Chain support for external PBL Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 4/7] qed*: qede_roce.[ch] -> qede_rdma.[ch] Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 5/7] qed*: Set rdma generic functions prefix Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 7/7] qed: SPQ async callback registration Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 13:00 ` [PATCH v4 net-next 6/7] qed: Wait for resources before FUNC_CLOSE Yuval Mintz
2017-06-20 13:00 ` Yuval Mintz
2017-06-20 16:35 ` [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP David Miller
[not found] ` <20170620.123551.765657502957371421.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-06-21 9:56 ` Or Gerlitz
[not found] ` <CAJ3xEMjyHidoAV9_VPkTM9dPdaXRFt8LmpcV_5iEvYEB+ujSmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-21 9:57 ` Or Gerlitz
2017-06-21 10:10 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621101018.GD1248@mtr-leonro.local \
--to=leon@kernel.org \
--cc=Michal.Kalderon@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.