Re: [PATCH] i2c: algo-bit: add support for I2C_M_STOP

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

Hi Jean,

> There's no problem with the scope. The problem is with the
> initialization. The way you did, did_stop gets reset to false with
> every iteration, which isn't what you want.

Ouch, where is my brown paper bag...

> I looked at how 10-bit addressing works again and in fact it is simply
> impossible to not use repeated start when reading from a 10-bit address
> slave. Only the first 2 bits of the 10-bit address are repeated in the
> read part of the transaction. If there was a stop between the two parts
> then there would be no way to know which 10-bit slave should send the
> data.

Which reminds me: Have you ever seen a 10-bit client device in the wild?
I wanted to buy one for testing reasons but was not able to locate one.
I only know a Renesas IP core which has 10-bit slave capability (but no
driver support for that yet).

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]