From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbdFUXTO (ORCPT ); Wed, 21 Jun 2017 19:19:14 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33202 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbdFUXTN (ORCPT ); Wed, 21 Jun 2017 19:19:13 -0400 Date: Wed, 21 Jun 2017 16:19:05 -0700 From: Stephen Hemminger To: Arnd Bergmann Cc: Stephen Hemminger , netdev@vger.kernel.org, Haiyang Zhang , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, "David S. Miller" Subject: Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly Message-ID: <20170621161905.340c2be2@xeon-e3> In-Reply-To: <20170621221714.278724-1-arnd@arndb.de> References: <20170621221714.278724-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jun 2017 00:16:37 +0200 Arnd Bergmann wrote: > This structure member is hidden behind CONFIG_SYSFS, and we > get a build error when that is disabled: > > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels': > drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh': > drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'? > > As the value is only set once to the argument of alloc_netdev_mq(), > we can compare against that constant directly. > > Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") > Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels") > Signed-off-by: Arnd Bergmann Yes this makes sense. The checks when changing values with ethtool are to avoid to large a value > 64. Signed-off-by: Stephen Hemminger